Issue 17: Fixes to data.table assignment #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
approved these changes
May 10, 2024
There was a problem hiding this comment.
This looks good and agree we can just watch out for further instances. I also agree that we need CI in place with nascent unit tests ASAP to making development safer.
Prior to merging would be okay to add yourself as a package contributor (as per the epinowcast community contributions guidelines)?
Closed
|
I have added myself as contributor in commit 16e94a4. |
seabbs
approved these changes
May 10, 2024
seabbs
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 358d4706f12e5c68058a627f9fa101d8e40eae76 [formerly efd2f7e7a841c31d86106f231ebeab82989de206] Former-commit-id: 59460a126c53f6fa91f66c3f51ec3b405d4069f0
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 4306d40 Former-commit-id: 922dc6b29c49be1c61ed9cb5f71a2ab986dbb470
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 4306d40 Former-commit-id: 922dc6b29c49be1c61ed9cb5f71a2ab986dbb470
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 4306d40 Former-commit-id: 922dc6b29c49be1c61ed9cb5f71a2ab986dbb470
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 358d4706f12e5c68058a627f9fa101d8e40eae76 [formerly efd2f7e7a841c31d86106f231ebeab82989de206] Former-commit-id: 59460a126c53f6fa91f66c3f51ec3b405d4069f0
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 358d4706f12e5c68058a627f9fa101d8e40eae76 [formerly efd2f7e7a841c31d86106f231ebeab82989de206] Former-commit-id: 59460a126c53f6fa91f66c3f51ec3b405d4069f0 Former-commit-id: bb53303
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 4306d40 Former-commit-id: 922dc6b29c49be1c61ed9cb5f71a2ab986dbb470 Former-commit-id: f72c2ad343194371b9e2018e076c50c9c4fd9c3c [formerly 1308111] Former-commit-id: 81aa52f128e208738eae6b827d75ec32a453858f
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Add omitted assignments * Correct typo (draw to draws) as suggested by seabbs * Add Adam Howes as contributor Former-commit-id: 4306d40 Former-commit-id: 922dc6b29c49be1c61ed9cb5f71a2ab986dbb470 Former-commit-id: f72c2ad343194371b9e2018e076c50c9c4fd9c3c [formerly 1308111] Former-commit-id: 81aa52f128e208738eae6b827d75ec32a453858f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #17.
It adds some missing assignments, based on looking through #3 and correcting the issues that I can spot.
As the package doesn't have testing (I think) I'm unsure about how I can test my changes (or be sure that I've got all of them). Open to suggestions on how to do this. Could be that we should move forward on #5 as a priority.
Checklist
drop_zero()function