Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 15: Remove excess models #28

Merged
merged 3 commits into from
May 13, 2024
Merged

Issue 15: Remove excess models #28

merged 3 commits into from
May 13, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented May 13, 2024 •
edited
Loading

Description

This PR closes #15.

Remove all models but latent_truncation_censoring_adjusted_delay().

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes
Copy link
Collaborator Author

athowes commented May 13, 2024 •
edited
Loading

Remaining issues here I think are:

  • Need to update documentation (e.g. do document())
  • Need to remove use of functions in vignette
  • Perhaps there are functions which only are used in conjuction with a deprecated function?

@athowes
Copy link
Collaborator Author

athowes commented May 13, 2024

The vignette code probably doesn't work as expected at the moment, but seeing as we have other issues to fix that soon and it is on eval = FALSE I don't think that should stop us from merging this.

@athowes athowes requested a review from seabbs May 13, 2024 14:15
@seabbs seabbs enabled auto-merge May 13, 2024 15:32
seabbs
seabbs approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Looks good.

@seabbs seabbs added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit e587081 May 13, 2024
1 of 2 checks passed
@seabbs
Copy link
Contributor

seabbs commented May 13, 2024

Perhaps there are functions which only are used in conjuction with a deprecated function?

Yes there are and this is partly where the discussion around having variables for events and delays comes in (as this model only users the former. I think (as you also appear to have felt) that this can be addressed in a later issue/PR.

@seabbs seabbs deleted the remove-model-functions branch May 13, 2024 15:34
seabbs pushed a commit that referenced this pull request Jan 10, 2025
@athowes
Issue 15: Remove excess models (#28)
5c88933 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: 95362d208fef12a4483fc803037f5be578ed0a53 [formerly 1359df037333fc2a1774cfac576c02fa39bb094d]
Former-commit-id: 7efe70b1c5326d209c746e12a374c11b43f25a78
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
de1d988 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: e587081
Former-commit-id: 7323c96f53e182fe4093cf8c6312e4e72ca52283
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
2304386 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: e587081
Former-commit-id: 7323c96f53e182fe4093cf8c6312e4e72ca52283
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
4ba60ea 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: e587081
Former-commit-id: 7323c96f53e182fe4093cf8c6312e4e72ca52283
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
6a9e66f 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: 95362d208fef12a4483fc803037f5be578ed0a53 [formerly 1359df037333fc2a1774cfac576c02fa39bb094d]
Former-commit-id: 7efe70b1c5326d209c746e12a374c11b43f25a78
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
900de95 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: 95362d208fef12a4483fc803037f5be578ed0a53 [formerly 1359df037333fc2a1774cfac576c02fa39bb094d]
Former-commit-id: 7efe70b1c5326d209c746e12a374c11b43f25a78
Former-commit-id: 6a9e66f
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
4623b53 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: e587081
Former-commit-id: 7323c96f53e182fe4093cf8c6312e4e72ca52283
Former-commit-id: 8c822918b0377dec709d35d8d8f46112aea7ed70 [formerly 4ba60ea]
Former-commit-id: d0ed99ef1ee7d3c8c0797d2238cea427dd44b9b3
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Issue 15: Remove excess models (#28)
12ccdc5 
* Remove all models apart from latent_truncation_censoring_adjusted_delay()

* Document package functions

* Remove deprecated models from vignette

Former-commit-id: e587081
Former-commit-id: 7323c96f53e182fe4093cf8c6312e4e72ca52283
Former-commit-id: 8c822918b0377dec709d35d8d8f46112aea7ed70 [formerly 4ba60ea]
Former-commit-id: d0ed99ef1ee7d3c8c0797d2238cea427dd44b9b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Which models to keep?
2 participants
@athowes @seabbs