Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #147: Remove cmdstanr from remote #356

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Oct 1, 2024

Description

This draft PR closes #147.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes
Copy link
Collaborator Author

athowes commented Oct 2, 2024

As discussed in F2F:

  • This PR is making progress on the roadmap to the package being on CRAN
  • Although now we don't have cmdstanr in depends, we do have it in suggests
  • This means that we have core package functionality like epidist::epidist() which relies on a suggested package which is bad
  • Possible route away from this is to switch backend = "cmdstanr" to either no default or another default (I think only available is "rstan")

@seabbs do you know your preference on route forward from here?

@seabbs
Copy link
Contributor

seabbs commented Oct 2, 2024

I think make a new issue for handling this with my preference being to stop being opinionated about the backend in the core package. We can talk about doing so (and how to) in the vignettes. The minimal version is we use rstan everywhere and put a comment about preferring cmdstanr in the FAQ

@athowes athowes marked this pull request as ready for review October 2, 2024 10:23
@seabbs seabbs enabled auto-merge (squash) October 2, 2024 10:50
@seabbs seabbs disabled auto-merge October 2, 2024 10:57
@seabbs seabbs merged commit 6ee9839 into main Oct 2, 2024
8 checks passed
@seabbs seabbs deleted the remove-cmdstanr-remote branch October 2, 2024 10:57
seabbs pushed a commit that referenced this pull request Jan 10, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3]
Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 6ee9839
Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 6ee9839
Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 6ee9839
Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3]
Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3]
Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1
Former-commit-id: 88f0953
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 6ee9839
Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
Former-commit-id: bde4c96ef6c5a1db1f33a65eee29cbe8a987f296 [formerly 5d1af31]
Former-commit-id: a4407652c81af30af0071da5568ea77bd0e8478c
seabbs pushed a commit that referenced this pull request Jan 21, 2025
* Remove cmdstanr from Remotes

* Move into Additional_repositories

* Use stable release version rather than latest

* Use R universe version of cmdstanr and add to GH actions

* Move cmdstanr from Imports to Suggests

* Remove import statement in package

Former-commit-id: 6ee9839
Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
Former-commit-id: bde4c96ef6c5a1db1f33a65eee29cbe8a987f296 [formerly 5d1af31]
Former-commit-id: a4407652c81af30af0071da5568ea77bd0e8478c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cmdstanr remote dependency
2 participants