-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #147: Remove cmdstanr
from remote
#356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in F2F:
@seabbs do you know your preference on route forward from here? |
I think make a new issue for handling this with my preference being to stop being opinionated about the backend in the core package. We can talk about doing so (and how to) in the vignettes. The minimal version is we use |
seabbs
approved these changes
Oct 2, 2024
seabbs
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3] Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 6ee9839 Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 6ee9839 Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 6ee9839 Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3] Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 82a8496410e085d1473884d2053aeeaf6098f881 [formerly 0ea27be8098a9c67d003a259a5667e55c9ce2af3] Former-commit-id: 19a0530e82757681e05176ba39546e99b3b85ec1 Former-commit-id: 88f0953
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 6ee9839 Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf Former-commit-id: bde4c96ef6c5a1db1f33a65eee29cbe8a987f296 [formerly 5d1af31] Former-commit-id: a4407652c81af30af0071da5568ea77bd0e8478c
seabbs
pushed a commit
that referenced
this pull request
Jan 21, 2025
* Remove cmdstanr from Remotes * Move into Additional_repositories * Use stable release version rather than latest * Use R universe version of cmdstanr and add to GH actions * Move cmdstanr from Imports to Suggests * Remove import statement in package Former-commit-id: 6ee9839 Former-commit-id: 7d9b5e32d8be79d554b92b7f7b7bdaa3f07eeddf Former-commit-id: bde4c96ef6c5a1db1f33a65eee29cbe8a987f296 [formerly 5d1af31] Former-commit-id: a4407652c81af30af0071da5568ea77bd0e8478c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR closes #147.
Checklist