Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #193: Swap to num_elements from size #194

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Issue #193: Swap to num_elements from size #194

merged 2 commits into from
Feb 5, 2025

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Feb 5, 2025

Description

This PR closes #193 by as the title swapping to num_elements in the stan code. This seems to have no detrimental impact and fixes the reported compilation edge case as shown in epinowcast/epidist#524

[Describe the changes that you made in this pull request.]

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.85%. Comparing base (be0ae95) to head (8f8e158).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          10       10           
  Lines         524      524           
=======================================
  Hits          518      518           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review).

Copy link
Contributor Author

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (self-review).

@seabbs seabbs merged commit cb9017d into main Feb 5, 2025
11 of 12 checks passed
@seabbs seabbs deleted the get-rid-of-size branch February 5, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of size() causes compilation errors
1 participant