Issue 34: rephrase integral as an ODE #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #34.
Under the hypothesis that more work has been put into the ODE solvers vs the integrator and that they may therefore be more stable, I recharacterised the integral as an ODE problem and solved it using the
ode_rk45
solver (likely worth exploring other options as well as tolerances). This appears to give a 4-5 times speed up and on the test data has no stability issues (i.e no chains out of 600 failed).I am very unclear as to exactly why apart from above logic about dev time spent.
As part of testing this I have made the simulated logic significantly harder (a mix of window lengths and observation times).
Checklist