Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class() and attr() instead of structure() #184

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

jamesmbaazam
Copy link
Member

@jamesmbaazam jamesmbaazam commented Jan 25, 2024

This PR fixes #183 by replacing the use of structure() to construct a class. The lintr suggests using a call to class() followed by calls to attr().

This PR will be merged ahead of #182 to fix the CI warnings there.

@jamesmbaazam jamesmbaazam self-assigned this Jan 25, 2024
@jamesmbaazam jamesmbaazam added this to the v0.1.0 milestone Jan 25, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5a3007) 99.26% compared to head (daa2e19) 99.26%.
Report is 1 commits behind head on main.

❗ Current head daa2e19 differs from pull request most recent head 62e522c. Consider uploading reports for the commit 62e522c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   99.26%   99.26%   -0.01%     
==========================================
  Files           8        8              
  Lines         684      682       -2     
==========================================
- Hits          679      677       -2     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesmbaazam jamesmbaazam merged commit 26748ba into main Jan 25, 2024
7 checks passed
@jamesmbaazam jamesmbaazam deleted the undesirable-function-lintr branch January 25, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Fix [undesirable_function_linter] error
2 participants