Skip to content

Commit

Permalink
Fix lint errores
Browse files Browse the repository at this point in the history
  • Loading branch information
@erseco
erseco committed Nov 22, 2024
1 parent bf46b3d commit 4bffab9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ARG ARCH=
FROM ${ARCH}alpine:3.20

LABEL Maintainer="Ernesto Serrano <info@ernesto.es>" \
Description="Lightweight container with Nginx & PHP-FPM based on Alpine Linux."
LABEL maintainer="Ernesto Serrano <info@ernesto.es>" \
description="Lightweight container with Nginx & PHP-FPM based on Alpine Linux."

# Install packages
RUN apk --no-cache add \

Check failure on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / buildx 

DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

Check failure on line 8 in Dockerfile

View workflow job for this annotation

GitHub Actions / buildx 

DL4006 warning: Set the SHELL option -o pipefail before RUN with a pipe in it. If you are using /bin/sh in an alpine image or if your shell is symlinked to busybox then consider explicitly setting your SHELL to /bin/ash, or disable this check
Expand Down Expand Up @@ -51,7 +51,7 @@ RUN apk --no-cache add \
| xargs -r apk info --installed \
| sort -u \
)" \
&& apk add --no-cache $runDeps \
&& apk add --no-cache "$runDeps" \
&& apk del .gettext \
&& mv /tmp/envsubst /usr/local/bin/ \
# Remove alpine cache
Expand All @@ -78,6 +78,8 @@ EXPOSE 8080
# Ensure /bin/docker-entrypoint.sh is always executed
ENTRYPOINT ["/bin/docker-entrypoint.sh"]

# Set SHELL to use pipefail
SHELL ["/bin/ash", "-o", "pipefail", "-c"]

# Configure a healthcheck to validate that everything is up&running
HEALTHCHECK --timeout=10s CMD curl --silent --fail http://127.0.0.1:8080/fpm-ping || exit 1
Expand Down

0 comments on commit 4bffab9

Please sign in to comment.