Default locale

[holzi1005]

Summary by CodeRabbit

• New Features

  • Introduced a new environment variable intl_default_locale to set the default locale for PHP, enhancing internationalization support.
  • Updated documentation to include detailed instructions on the new environment variable and Composer installation process.

• Documentation

  • Enhanced the README.md with clear guidelines on the new locale configuration and multi-stage build examples for Composer.

• Configuration

  • Added intl.default_locale setting in the PHP configuration to utilize the new environment variable for locale management.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the Dockerfile, README.md, and a PHP configuration file (custom.ini). An environment variable intl_default_locale is added to the Dockerfile, which sets the default locale for PHP internationalization. The README.md is updated to document this new variable and enhance the instructions for setting up the Docker environment, including a more detailed guide on installing Composer. Additionally, the custom.ini file is updated to utilize the new environment variable for configuring PHP's locale settings.

Changes

File	Change Summary
Dockerfile	Added environment variable intl_default_locale with value en_US.
README.md	Updated to include details about intl_default_locale, its default value, and expanded Composer installation instructions.
rootfs/etc/php83/conf.d/custom.ini	Added configuration setting intl.default_locale= "$intl_default_locale" to utilize the new environment variable.

Possibly related PRs

• Add PHP_DATETIMEZONE as ENV Variable #33: The addition of the date_timezone environment variable in the Dockerfile and its usage in the custom.ini file is related to the changes made in the main PR, which also involves modifying environment variables in the Dockerfile and PHP configuration.

Suggested reviewers

• erseco

Poem

In a Docker world, so bright and new,
A locale set, for me and you.
With PHP's charm, it knows the way,
To greet us right, each and every day.
Composer's guide, now clear and bright,
Hop along, let's code with delight! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[holzi1005]

Hello @erseco,

I hope you are doing well. I follow up with a new pull request to add the intl. default_locale in PHP. With this setting, the docker image is even more customization and by default all stays the same.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

rootfs/etc/php83/conf.d/custom.ini (1)

16-16: LGTM! Consider adding a descriptive comment.

The intl.default_locale setting is correctly configured to use the environment variable.

Consider adding a comment to explain the purpose of this setting:

+; Sets the default locale for PHP's internationalization functions
 intl.default_locale= "$intl_default_locale"

README.md (1)

172-172: LGTM! Consider enhancing the documentation.

The documentation for intl_default_locale is clear and consistent with the implementation.

Consider adding:

1. Examples of other common locales (e.g., 'fr_FR', 'de_DE', 'es_ES')
2. Note about the impact on PHP's internationalization functions
3. Link to a list of available locales

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 0a83bc4 and 77da652.

📒 Files selected for processing (3)

• Dockerfile (1 hunks)
• README.md (1 hunks)
• rootfs/etc/php83/conf.d/custom.ini (1 hunks)

🔇 Additional comments (1)

Dockerfile (1)

99-100: LGTM! Verify locale availability in the container.

The addition of intl_default_locale=en_US follows the existing environment variable pattern and uses a valid locale format.

Let's verify that the locale is available in the container:

[erseco]

Nice! Thanks for your help!