Make access_key_id a secret field

Author: theely

src/firecrest/config.py

@@ -197,7 +197,7 @@ class Storage(BaseModel):
         ..., description="Private/internal endpoint URL for the storage."
     )
     public_url: str = Field(..., description="Public/external URL for the storage.")
-    access_key_id: str = Field(
+    access_key_id: SecretStr = Field(
         ..., description="Access key ID for S3-compatible storage."
     )
     secret_access_key: LoadFileSecretStr = Field(

src/firecrest/dependencies.py

@@ -334,7 +334,7 @@ async def __call__(self):
             "s3",
             region_name=settings.storage.region,
             aws_secret_access_key=settings.storage.secret_access_key.get_secret_value(),
-            aws_access_key_id=settings.storage.access_key_id,
+            aws_access_key_id=settings.storage.access_key_id.get_secret_value(),
             endpoint_url=self.url,
             config=AioConfig(signature_version="s3v4"),
         ) as client:

tests/conftest.py

@@ -66,7 +66,7 @@ async def s3_client():
         "s3",
         region_name=settings.storage.region,
         aws_secret_access_key=settings.storage.secret_access_key,
-        aws_access_key_id=settings.storage.access_key_id,
+        aws_access_key_id=settings.storage.access_key_id.get_secret_value(),
         endpoint_url=settings.storage.private_url.get_secret_value(),
         config=AioConfig(signature_version="s3v4"),
     ) as client: