Added script_path to submit jobs

[jpdorsch]

• Job submission via CLI can be done now pointing to a path in the remote cluster ( script_path)
• Parameter script now is optional
• If script_path is provided in system that is configured to use the API, then it checks that also the script is provided. If not, then the submission is not possible

[theely]

Should we call this "Example with inline script"?

[theely]

If we aim to abstract the scheduler type and its behaviour, should we transparently handle this case?
Instead of returning an error, we could force the use of the slurm_cli_client.py
To do so, change the scheduler client dependency to: Depends(SchedulerClientDependency(force_cli_client=True)), on the post job route

The flip side is that job submission via Slurm REST API will never be called. At least until Slurm implements the ability to provide a script path also via REST API.

[jpdorsch]

I was thinking about that idea.
My main concern here is that this is only possible with SLURM. What if the scheduler used as API doesn't provide a CLI version installed in the same system?

[theely]

Agreed, the current implementation is not ideal.
With force_cli_client=True, it is the route function that implements the logic of using the CLI or the REST API. Instead, this decision should be delegated to the SchedulerClientDependency class or the Slurm clint class.

I would proceed as follows:

• for the time being, use: Depends(SchedulerClientDependency(force_cli_client=True))
• open an issue to remove the force_cli_client parameter. Instead, we should create a new Slurm client that integrates both the CLI and the REST clients and "automatically" routes the requests via the correct channel.