-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new design for FileContributors #14898
base: dev
Are you sure you want to change the base?
feat: use new design for FileContributors #14898
Conversation
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @konopkja, could you take a look at this? Let me know if anything needs improvement! |
@konopkja Sure, I'll work on this soon! |
Hey @konopkja , I’ve adjusted the gap and made the updates for mobile. I also want to point out a few additional changes I made that you might not notice:
Could you take a look at those as well and let me know if everything looks fine? Appreciate your feedback! |
Hey @JoeChenJ it looks perfect! Really appreciate this particular contribution <3 |
shall we discuss extending this component to other pages outside developer docs or would it be better tackled in another PR? |
I think it would be best to merge this PR first, and then we can extend it in another one, as it might take a bit more time |
…com/JoeChenJ/ethereum-org-website into Use_new_design_for_FileContributors
Hey @konopkja, I've made some progress on the extension—the component is now available at the end of the markdown pages. Since this PR is still open, I've pushed the changes here! |
|
@JoeChenJ, great contribution! Thank you From my side, this component should always be at the end of the content, before the callouts and widgets. I would add a border-top to it. See if this screenshot helps. Are you thinking of all content pages? Something like all pages minus (homepage & Hubpages). Is this the goal? |
@nloureiro thank you for the guidance! Adding a border-top looks much better. I was planning to add this component on every page, but not sure if it fits well across all designs. Do you think we should exclude certain pages? Would love to get your thought on it! |
There are pages, like the homepage and hub pages, where this does not make sense. Another comment: maybe change the copy to : It would be more in line with the copy on the footer, or maybe remove the date from the footer. I don't know. @konopkja, what do you think? Question: what do you have in mind for its component? You need to go to every page manually and add this, right? |
Yes, for React pages, I need to manually add it on every one. For homepage and hub pages, there are still some GitHub contributors who have fixed bugs or migrated components, as well as Crowdin contributors who help translate the strings (it's still a bit tricky for me to capture translators on React pages though). If our goal is to recognize the efforts of every contributor, I think it could still be meaningful on these pages. However, I’m concerned about whether adding it to these pages makes sense from a UX or design perspective, what do you think? |
Hi, i think it make some sense to keep the component on most pages with the alternation nuno proposed. I checked the latest deploy and think it looks good. I would probably not include it on homepage for now even though there have been other contributors. Furthermore i realized that we have no call to action inside the modal window. @JoeChenJ could you please add link to our https://deploy-preview-14898--ethereumorg.netlify.app/en/contributing/ (new tab) in there? Higlighted word could be a link. |
Description
Use new design for
FileContributors
Related Issue
#8024 & #14473