Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadCN]: Replace Chakra radio hooks with RadioGroup Radix #14914

Conversation

TylerAPfledderer
Copy link
Contributor

Description

Replaces Chakra radio hooks with RadioGroup from Radix for the Quiz Widget question choices.

Uses direct import of RadioGroup to maintain custom styling.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 395127d
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/67afc039714dd00008179edf
😎 Deploy Preview https://deploy-preview-14914--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 46 (🔴 down 5 from production)
Accessibility: 95 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@TylerAPfledderer TylerAPfledderer changed the title [ShadCN[: Replace Chakra radio hooks with RadioGroup Radix [ShadCN]: Replace Chakra radio hooks with RadioGroup Radix Feb 15, 2025
Comment on lines +130 to +133
"data-[state='checked']:data-[answer-visible]:bg-error",
"data-[state='checked']:data-[answer-visible]:data-[selected-correct]:bg-success",
"data-[state='checked']:text-white",
"data-[state='checked']:not-[data-answer-visible]:bg-primary"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: clean up these style checks!

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pettinarip pettinarip merged commit f632a0e into ethereum:dev Feb 17, 2025
10 checks passed
@TylerAPfledderer TylerAPfledderer deleted the refactor/quiz-radio-remove-chakra-hooks branch February 17, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants