ethdb: Implement DeleteRange in batch #31947
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the compilation. |
hadv
force-pushed
the
batch-range-deletion
branch
from
23a61a6 to
6f76fec
Compare
fjl
reviewed
Jun 18, 2025
core/rawdb/table.go
Outdated
| // The nilness will be lost by adding the prefix, explicitly converting it | ||
| // to a special flag representing the end of key range. | ||
| if end == nil { | ||
| end = bytes.Repeat([]byte{0xff}, 32) |
There was a problem hiding this comment.
Won't this have an issue if the key is larger than 32 bytes?
There was a problem hiding this comment.
Yeah. The only possible scenario to hit this scenario is hash-based trie node key, which can in theory be bytes.Repeat([]byte{0xff}, 32). It's the rationale I choose this value as the special marker.
Btw, we also use it for Pebble compaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #31945