core,miner,params: implement EIP-7934 - RLP Execution Block Size Limit #31990
Conversation
jwasinger
requested review from
fjl,
karalabe,
gballet,
rjl493456442,
zsfelfoldi and
MariusVanDerWijden
as code owners
miner/worker.go
Outdated
| @@ -391,6 +394,10 @@ func (miner *Miner) commitTransactions(env *environment, plainTxs, blobTxs *tran | |||
| continue | |||
| } | |||
|
|
|||
| if miner.chainConfig.IsOsaka(env.header.Number, env.header.Time) && env.size+tx.Size() > params.BlockRLPSizeCap { | |||
There was a problem hiding this comment.
Also, the block body size is also influenced by other things, such as withdrawals. So we need to add a bit of buffer into the size limit here. For the withdrawals, we may be able to add their true size into env.size before adding transactions.
…if we would hit the size cap when filling it with txs
| @@ -273,6 +305,7 @@ func (miner *Miner) commitTransaction(env *environment, tx *types.Transaction) e | |||
| } | |||
| env.txs = append(env.txs, tx) | |||
| env.receipts = append(env.receipts, receipt) | |||
| env.size += tx.Size() | |||
There was a problem hiding this comment.
It only applies the non-blob-tx, but for the blob-tx, the tx withouth sidecar should also be considered for the inclusion size.
There was a problem hiding this comment.
I think blobs don't need to be included here, since they do not become a part of the block.
There was a problem hiding this comment.
Gary's point was that his path wasn't called for blob transactions. We need to factor the blob transaction without the sidecar into the size calc.
There was a problem hiding this comment.
i've since updated this pr.
…ribute to the RLP-encoded block
…t to add when creating a block
|
|
||
| for _, withdrawal := range genParam.withdrawals { | ||
| if int(work.size)+params.WithdrawalSize > maxBlockSize { | ||
| break |
There was a problem hiding this comment.
From the CL team:
potuz — 2025/6/10 21:11
This makes the payload invalid
Technically it will make the consensus block that contains that payload invalid.
Probably we need to put a note here, at least adding a warning log that a part of withdrawals specified by the CL are discarded due to the size restriction. In practice, it's impossible to occur.
No description provided.