Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce an exception type for the AST Json importer and use as replacements for solAsserts #15854

Open
matheusaaguiar opened this issue Feb 12, 2025 · 0 comments
Open

Introduce an exception type for the AST Json importer and use as replacements for solAsserts #15854

matheusaaguiar opened this issue Feb 12, 2025 · 0 comments
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it.

Comments

@matheusaaguiar
Copy link
Collaborator

Suggested here: #15463 (comment)

The AST Json Importer has many instances of solAssert being used for validation/error messaging. As suggested in the linked comment, it would be better to have a specific exception for those cases.
@matheusaaguiar matheusaaguiar added low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it. labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low effort There is not much implementation work to be done. The task is very easy or tiny. low impact Changes are not very noticeable or potential benefits are limited. nice to have We don’t see a good reason not to have it but won’t go out of our way to implement it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matheusaaguiar