Adding module-descriptors again.

[ethlo]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.34%. Comparing base (5a4d236) to head (1d838e9).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main      #42   +/-   ##
=========================================
  Coverage     89.34%   89.34%           
  Complexity      314      314           
=========================================
  Files            27       27           
  Lines           732      732           
  Branches        125      125           
=========================================
  Hits            654      654           
  Misses           47       47           
  Partials         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[merks]

Thank you.

[ethlo]

@lscoughlin Is this acceptable now?

[lscoughlin]

The maven plugin you're using to generate the the module-info.java just doesn't work.

[ethlo]

The maven plugin you're using to generate the the module-info.java just doesn't work.

Can you please point out what is the problem, as I need to keep this plugin to have the OSGi generated AFAIK.

I decompiled the META-INF/versions/9/module-info.class using IntelliJ:

module com.ethlo.time.itu {
    exports com.ethlo.time;
    exports com.ethlo.time.token;
}

Is this not correct?

[merks]

I can't judge so much of this but I see it's bundle packaging and using maven-bundle-plugin so that looks good to me. If at some point there is a repo with the snapshot artifact I can have a look at that...

[ethlo]

I can't judge so much of this but I see it's bundle packaging and using maven-bundle-plugin so that looks good to me. If at some point there is a repo with the snapshot artifact I can have a look at that...

Snapshots are available here: https://oss.sonatype.org/content/repositories/snapshots

[ethlo]

@lscoughlin It does indeed seem to work. I took the time to create a super-simple sample project, and this seems to work just fine. I just added this to the sample project:

module com.example.modularproject {
    requires com.ethlo.time.itu;
}

[lscoughlin]

java -p [simpelproject.jar] --list-modules and see if your module is declared.
Because it's not showing up for itu, and i get runtime errors from the new build with exactly the same message.

[merks]

Snapshots are available here: https://oss.sonatype.org/content/repositories/snapshots

When I go there, it just shows:

I do have an account there and tried it when being logged in as well. Maybe the staging repo isn't visible or I need a longer URL for it?

[ethlo]

I do have an account there and tried it when being logged in as well. Maybe the staging repo isn't visible or I need a longer URL for it?

Sorry, i just gave you the base-path of the repo: https://oss.sonatype.org/content/repositories/snapshots/com/ethlo/time/itu/1.12.0-SNAPSHOT/

[ethlo]

java -p [simpelproject.jar] --list-modules and see if your module is declared. Because it's not showing up for itu, and i get runtime errors from the new build with exactly the same message.

Thanks for bearing with me!

I created https://github.com/ethlo/simple-modular-demo so we can compare notes and I have something reproducible.

I tested with java --module-path target/itu-1.12.0-SNAPSHOT.jar --list-modules | grep itu

Output:

com.ethlo.time.itu@1.12.0-SNAPSHOT file:///home/morten/dev/ethlo/itu/target/itu-1.12.0-SNAPSHOT.jar

I do not try to make this difficult, but I would like to have something to evaluate and test this going forward.

[lscoughlin]

Something must of been wrong with my build then. :/
you can test it by just running something that requires it on the module path.

[ethlo]

Something must of been wrong with my build then. :/ you can test it by just running something that requires it on the module path.

Could you pull the simple project and have a look that I have not done anything wrong? Could perhaps serve as a clean slate for evaluating this? Thank you.

[lscoughlin]

That should do it. If you have sample service have a static void main method so it's launch-able you can launch it after build with java --module-path ./target --add-modules=ALL-SYSTEM com.example.modularproject/sample/SampleService

( you'll have to copy the lib into ./target too, but you can do that with the mvn-dependencies:copy plugin )

From the sample project your specify the module name as different than you have in the past ( com.ethlo.time vs com.ethlo.time.itu ) and so you should see the issue depending ( required module missing ). networknt binds against the com.ethlo.time module name.

[ethlo]

The com.ethlo.time is not correct, as both ITU and Chronograph would be in the same namespace/module then. I'd like to make things right with the 1.12 release, so com.ethlo.time.itu is intended to stay. I assume this is relatively unproblematic to update for a consumer of the library?

[ethlo]

I added a main method if you want to run it, btw. I see it already builds fine on the the GitHub action (https://github.com/ethlo/simple-modular-demo/actions/runs/13291400617/job/37112862158)

[ethlo]

@lscoughlin I updated the sample project and made sure it works fine. Are these changes acceptable for a 1.12.0 release, from your perspective?

[lscoughlin]

Yup -- that's perfect. I just want to note that your previous module name was com.ethlo.time not com.ethlo.time.itu so you're going to break downstream module dependencies like networknt's :).