DC API pre-phase #369
DC API pre-phase #369
Conversation
vafeini
force-pushed
the
feat/dc_api_prephase
branch
3 times, most recently
from
ccc94ea to
9efad0a
Compare
…ent to be executed as one step that validates and resolves the authorization request
… in wallet metadata set presentation_definition_uri_supported to false by default
…i-signed authorization requests.
vafeini
force-pushed
the
feat/dc_api_prephase
branch
from
9efad0a to
c65edb5
Compare
| Value of presentation_definition_uri_supported in wallet metadata will be set to false by default | ||
| """, | ||
| ) | ||
| val presentationDefinitionUriSupported: Boolean = false, |
There was a problem hiding this comment.
Consider removing it from the constructor.
Alternatively, keep the constructor argument but remove the val
...n/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/DefaultAuthorizationRequestResolver.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/DefaultAuthorizationRequestResolver.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/DefaultAuthorizationRequestResolver.kt
Outdated
Show resolved
Hide resolved
...n/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/DefaultAuthorizationRequestResolver.kt
Outdated
Show resolved
Hide resolved
…troduced JWSSigned data class for signed requests.
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/RFC7515Spec.kt
Outdated
Show resolved
Hide resolved
…sSigned with sealed interface JwsJson with 2 members, General and Flattened.
src/main/kotlin/eu/europa/ec/eudi/openid4vp/internal/RFC7515Spec.kt
Outdated
Show resolved
Hide resolved
| val signature: Base64UrlNoPadding, | ||
| ) | ||
|
|
||
| @Serializable(with = Base64UrlNoPaddingSerializer::class) |
There was a problem hiding this comment.
Consider implementing Base64UrlNoPadding as a value class have a value attribute.
Perhaps
fun <T> decode( f: (ByteArray) ->T): Tcan be addedfun decode(): ByteArray = decode { it }
There was a problem hiding this comment.
Base64UrlNoPadding is already a data class with one value attribute. Do you mean to have this attribute be a ByteArray?
There was a problem hiding this comment.
No i mean literally instead of data class to defined it as value class
...n/kotlin/eu/europa/ec/eudi/openid4vp/internal/request/DefaultAuthorizationRequestResolver.kt
Outdated
Show resolved
Hide resolved
| SignedJWT.parse("${it.header.protected}.${jwsSigned.payload}.${it.signature}") | ||
| internal fun ReceivedRequest.Signed.toSignedJwts(): List<SignedJWT> = when (jwsJson) { | ||
| is JwsJson.Flattened -> listOf( | ||
| SignedJWT.parse("${jwsJson.protected}.${jwsJson.payload}.${jwsJson.signature}"), |
There was a problem hiding this comment.
Nimbus provides a class that is in par withJwsJson.Flattened named JWSObject
Consider JwsJson.Flattened -> JWSObject -> SignedJWT
There was a problem hiding this comment.
To be honest I don't see the benefit to go first to JWSObject and then to SignedJWT. JWSObject would have to be serialized to compact form and then call SignedJWT.parse() with no benefit doing that instead of calling directly SignedJWT.parse()
There was a problem hiding this comment.
I am not sure about this.
@ThreadSafe
public class SignedJWT extends JWSObject implements JWT {SignedJWT is a JWSObject
There was a problem hiding this comment.
True but what is the benefit converting JwsJson.Flattened to JWSObject and then to SignedJWT?
As a pre-phase before introducing DC API the following refactorings are perfomed as analyzed in #349
Unsinged-> equivalent to currentPlaindata classSigned-> is a new abstraction that merges the concerns of single-signed and multi-signed authorization request