Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/exclude configuration doesn't apply #261

Open
spleenjack opened this issue Oct 9, 2017 · 2 comments
Open

include/exclude configuration doesn't apply #261

spleenjack opened this issue Oct 9, 2017 · 2 comments

Comments

@spleenjack
Copy link

spleenjack commented Oct 9, 2017

retrolambda plugin 3.7 ignores the include/exclude configuration setting right now and transforms the whole project's code.

Some context: the new gradle plugin 3.x with desugaring cannot desugar the library projects actually, here is an issue about that: https://issuetracker.google.com/issues/67452341

So, we would like to build two different flavors in the future, the first flavor with retrolambda and with disabled desugaring, and the second flavor without retrolambda and with enabled desugaring. We asked to add the feature to enable/disable desaguring per flavor, since now this is possible only per project manner.

But this is useless if we can't use the feature to include/exclude retrolambda for specified variants.

Can you fix this?

@evant
Copy link
Owner

evant commented Oct 10, 2017

I think it stopped working after switching to the transform api. I was actually considering taking the feature out since it seemed nobody was using it. Shouldn't be too hard to fix, the transform needs to check if the variant is disabled and just copy all the files over instead of running retrolambda.

@mmitic-lotusflare
Copy link

@evant Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants