-
-
Notifications
You must be signed in to change notification settings - Fork 451
v0: Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-v0
Are you sure you want to change the base?
Conversation
Nice and clean PR. 0.x builds aren't working (need help or time to get them up and running again), but I'll try to verify this manually to see if it can be merged. |
I've tried to get |
I'm working on getting a GHA runner up and running for EventFlow that has Docker properly configured (Linux containers). |
@janrybka I have gotten builds up and running for v0 again. It left some merge conflicts with this PR though |
26b90d4
to
d9d24d9
Compare
It took a while, though I've made a rebase of changes on current state of All Best in the New Year! :) |
Job failed with no agents and I don't know how to retry it. I'll leave it for now. @rasmus, I need help... |
Hello there! We hope this message finds you well. We wanted to let you know that we have noticed that there has been As a result, we will be closing this pull request within the next seven days. If you still Thank you for your contributions and understanding. Best regards, |
The build requires a Windows runner. I'll get one running (GitHub's can be used as they don't support Linux containers)_ |
Details in of update in discussion: #1022 (comment)
PR contains minimal set of changes to make transfer to Microsoft.Data.SqlClient successful. Threat warning as errors caused problems for valnerable packages. I've updated only
Newtonsoft.Json
as this I could test. I didn't have any MongoDB or Owin project to test on, so these are now marked with "NoWarn" option. I could try to update those also, but in this case I'd go with Yurii's PR and update all.