Skip to content

v0: Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x #1027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop-v0
Choose a base branch
from

Conversation

janrybka
Copy link
Contributor

@janrybka janrybka commented Apr 3, 2024

Details in of update in discussion: #1022 (comment)

PR contains minimal set of changes to make transfer to Microsoft.Data.SqlClient successful. Threat warning as errors caused problems for valnerable packages. I've updated only Newtonsoft.Json as this I could test. I didn't have any MongoDB or Owin project to test on, so these are now marked with "NoWarn" option. I could try to update those also, but in this case I'd go with Yurii's PR and update all.

@rasmus
Copy link
Member

rasmus commented Apr 4, 2024

Nice and clean PR.

0.x builds aren't working (need help or time to get them up and running again), but I'll try to verify this manually to see if it can be merged.

@janrybka
Copy link
Contributor Author

janrybka commented Apr 5, 2024

I've tried to get build.ps1 up, but I only got it to run by commenting out #module nuget:?package=Cake.DotNetTool.Module.
Unfortunately, it hang on unit tests. I also didn't know how to knit it with GitHub workflow, so I gave up at the point.

@rasmus
Copy link
Member

rasmus commented Oct 19, 2024

I'm working on getting a GHA runner up and running for EventFlow that has Docker properly configured (Linux containers).

@rasmus rasmus changed the title Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x v0: Update from System.Data.SqlClient to Microsoft.Data.SqlClient in v0.x Oct 20, 2024
@rasmus
Copy link
Member

rasmus commented Oct 20, 2024

@janrybka I have gotten builds up and running for v0 again. It left some merge conflicts with this PR though

@janrybka
Copy link
Contributor Author

janrybka commented Jan 20, 2025

It took a while, though I've made a rebase of changes on current state of v0-develop and it awaits build. Locally it had build, so fingers crossed that it will pass all the tests :)

All Best in the New Year! :)

@janrybka
Copy link
Contributor Author

janrybka commented Jan 22, 2025

Job failed with no agents and I don't know how to retry it. I'll leave it for now. @rasmus, I need help...

Copy link

Hello there!

We hope this message finds you well. We wanted to let you know that we have noticed that there has been
no activity on this pull request for the past 90 days, which makes it a stale pull request.

As a result, we will be closing this pull request within the next seven days. If you still
think this pull request is necessary or relevant, please feel free to update it or leave a
comment within the next seven days.

Thank you for your contributions and understanding.

Best regards,
EventFlow

@github-actions github-actions bot added the stale label Apr 28, 2025
@rasmus rasmus removed the stale label Apr 28, 2025
@rasmus
Copy link
Member

rasmus commented Apr 28, 2025

The build requires a Windows runner. I'll get one running (GitHub's can be used as they don't support Linux containers)_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants