Add person memberships class

[ondenman]

In addition to the membership profile:

…members have a list of memberships reached via the 'Todas las legislaturas' link.

PersonMemberships returns a collection of MembershipRow objects. Each of these contains the legislature id, url and name of deputy. The url points to a separate profile page for each of the memberships. (That is, if a member has sat it terms 9,10, and 11, there will be a separate profile page for the member for these three terms.)

[chrismytton]

I don't think you need the Cookie class at all. You can just pass the cookie back exactly as you received it:

let(:header){ { 'Cookie' => profile_page_response.meta['set-cookie'] } }

However in my experimenting it seemed that there wasn't always a cookie in the response, so we should probably only be sending this when there's a cookie in the response.

Here's the script I've been using to experiment with the cookies that are being returned:

require 'open-uri'

def error?(res)
  if res.read.include?('missing string: error')
    warn "! Error"
  else
    warn "OK"
  end
end

memberships_url = 'http://www.congreso.es/portal/page/portal/Congreso/Congreso/Diputados/BusqForm?next_page=/wc/listadoFichas?idDiputado=338&idLegislatura=12'

warn "Requesting member page"
membership_page = open('http://www.congreso.es/portal/page/portal/Congreso/Congreso/Diputados/BusqForm?next_page=/wc/fichaDiputado?idDiputado=338&idLegislatura=12')

if membership_page.meta['set-cookie'].to_s.empty?
  warn "No Set-Cookie response header from membership page"
  warn "Requesting person memberships without Cookie"
  res = open(memberships_url)
  error?(res)
else
  warn "Requesting person memberships with Cookie"
  res = open(memberships_url, 'Cookie' => membership_page.meta['set-cookie'])
  error?(res)
end

[ondenman]

Yes. I'd somehow convinced myself that it wouldn't work. Works every time!