Skip to content

Commit f8a171c

Browse files
Adding analyzer feedback for tim-from-marketing concept exercise (#2754)
* Adding analyzer feedback for tim-from-marketing concept exercise * Adding another actionable comment when students use optionals * Update exercises/concept/tim-from-marketing/.meta/design.md Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com> * Removing essential comment --------- Co-authored-by: Sander Ploegsma <sanderploegsma@gmail.com>
1 parent f09920b commit f8a171c

File tree

1 file changed

+13
-0
lines changed
  • exercises/concept/tim-from-marketing/.meta

1 file changed

+13
-0
lines changed

exercises/concept/tim-from-marketing/.meta/design.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,16 @@
1818

1919
- `strings`: strings will be compared to null and basic methods from strings will be called.
2020
- `if-else-statements`: using a conditional statement.
21+
22+
## Analyzer
23+
24+
This exercise could benefit from the following rules in the [analyzer]:
25+
26+
- `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it using `null` instead.
27+
- `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead.
28+
Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios.
29+
30+
If the solution does not receive any of the above feedback, it must be exemplar.
31+
Leave a `celebratory` comment to celebrate the success!
32+
33+
[analyzer]: https://github.com/exercism/java-analyzer

0 commit comments

Comments
 (0)