Skip to content

Commit ed52a35

Browse files
committed
address pr comments, 2nd part
1 parent 51a71c8 commit ed52a35

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed
Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
You get part of the information and need to fills in the blanks. If the provided information is insufficient to calculate the rest, there should be an error "Insufficient information". If the data given is contradictory, there should be an error "Contradictory information" The full information about the jigsaw puzzle contains the following parts:
1+
You get part of the information and need to fills in the blanks.
2+
In case the data is insufficient or contradictory the user needs to be notified of the issue.
3+
The full information about the jigsaw puzzle contains the following parts:
24

35
- `pieces`: Number of pieces
46
- `border`: Number of border pieces
@@ -8,8 +10,10 @@ You get part of the information and need to fills in the blanks. If the provided
810
- `aspectRatio`: Aspect ratio of columns / rows
911
- `format`: Format of the puzzle: `"portrait" / "square" / "landscape" / "globe"`
1012

11-
For the rows and columns of a puzzle globe, assume an aspect ratio of 1.0, so rows and columns are identical.
13+
For the rows and columns of a puzzle globe, assume an aspect ratio of 1.0, so that rows and columns are identical.
1214

13-
Spoilt by the comfort of your helper, your friend now no longer wants to count border pieces. To help with estimating, you take the number of pieces and return an array of the possible numbers of rows and columns.
15+
Spoilt by the comfort of your helper, your friend now no longer wants to count border pieces.
16+
To help with estimating, you take the number of pieces and return an array of the possible numbers of rows and columns.
1417

15-
Start with the lowest number of rows and work your way up from there. While a single-row jigsaw puzzle might be a strange novelty, it is theoretically possible, so you should include this case.
18+
Start with the lowest number of rows and work your way up from there.
19+
While a single-row jigsaw puzzle might be a strange novelty, it is theoretically possible, so you should include this case.

exercises/jigsaw-puzzle/metadata.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
title = "Puzzle Helper"
2-
blurb = "Calculate data about puzzles"
3-
source = "atk just started another 1000-pieces puzzle when this idea hit him"
1+
title = "Jigsaw Puzzle"
2+
blurb = "Calculating the number of certain pieces (row/column/border/inside/etc.) of a jigsaw puzzle"
3+
source = "atk just started another 1000-pieces jigsaw puzzle when this idea hit him"

0 commit comments

Comments
 (0)