Skip to content

dnd-character: split into instructions and introduction #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 10, 2024

Conversation

ErikSchierboom
Copy link
Member

  • dnd-character: convert Note heading to exercism/note
  • dnd-character: grammar fix
  • dnd-character: split up into introduction and instructions

@ErikSchierboom ErikSchierboom requested a review from a team as a code owner April 5, 2024 08:14
@ErikSchierboom ErikSchierboom changed the title dnd character instructions introduction dnd-character: split into instructions and introduction Apr 5, 2024
@ErikSchierboom ErikSchierboom force-pushed the dnd-character-instructions-introduction branch from 61e1a5d to fdf0eb6 Compare April 5, 2024 08:14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've purposefully made the text a bit dramatic, to keep in line with the fantasy theme. If it's too much, let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably water it down a little, just for multilingual speakers (who aren't up to your standard!) But I like the story and the vibe! :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I reverted to my original version

Co-authored-by: Matthijs <19817960+MatthijsBlom@users.noreply.github.com>
ErikSchierboom and others added 2 commits April 9, 2024 09:04
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@BethanyG
Copy link
Member

BethanyG commented Apr 9, 2024

Couldn't make a suggestion, since this is a part of the exercise that didn't change. On line 6 of the instructions.md file:

You do this by rolling four 6-sided dice and record the sum of the largest three dice.

Should either be:

You do this by rolling four 6-sided dice and recording the sum of the largest three dice.
or
These six abilities have scores that are determined randomly
by rolling four 6-sided dice. The ability score should be recorded as the sum of the largest three dice.

@ErikSchierboom
Copy link
Member Author

@BethanyG Updated!

@ErikSchierboom ErikSchierboom merged commit 509729f into main Apr 10, 2024
7 checks passed
@ErikSchierboom ErikSchierboom deleted the dnd-character-instructions-introduction branch April 10, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants