-
-
Notifications
You must be signed in to change notification settings - Fork 555
dnd-character: split into instructions and introduction #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ErikSchierboom
commented
Apr 5, 2024
- dnd-character: convert Note heading to exercism/note
- dnd-character: grammar fix
- dnd-character: split up into introduction and instructions
61e1a5d
to
fdf0eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've purposefully made the text a bit dramatic, to keep in line with the fantasy theme. If it's too much, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll probably water it down a little, just for multilingual speakers (who aren't up to your standard!) But I like the story and the vibe! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I reverted to my original version
Co-authored-by: Matthijs <19817960+MatthijsBlom@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
Couldn't make a suggestion, since this is a part of the exercise that didn't change. On line 6 of the
Should either be: You do this by rolling four 6-sided dice and recording the sum of the largest three dice. |
@BethanyG Updated! |