-
-
Notifications
You must be signed in to change notification settings - Fork 554
kindergarten-garden: split description into introduction and instructions #2439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6109917
kindergarten-garden: split description into introduction and instruct…
ErikSchierboom d9b26a9
Update exercises/kindergarten-garden/introduction.md
ErikSchierboom 3b72462
Update exercises/kindergarten-garden/introduction.md
ErikSchierboom 0c6e851
Add table for plants
ErikSchierboom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 11 additions & 18 deletions
29
exercises/kindergarten-garden/description.md → ...cises/kindergarten-garden/instructions.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# Introduction | ||
|
||
The kindergarten class is learning about growing plants. | ||
The teacher thought it would be a good idea to give them actual seeds, plant them in actual dirt, and grow actual plants. | ||
ErikSchierboom marked this conversation as resolved.
Show resolved
Hide resolved
|
||
To this end, the children have put little cups along the window sills and planted one type of plant in each cup. | ||
The children got to pick their favorites from four available types of seeds: grass, clover, radishes, and violets. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the character encoding the plant this time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would a table make sense here or is that overkill?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️ What do others do think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm for adding the table. It's not clear what those strings are for at this point since we don't have the examples yet.
If we don't want a table, we can do a sentence like
Grass is marked on the diagram by "G", clover by "C", radishes by "R", and violets by "V".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a table.