Skip to content

Update docs for the Luhn exercise #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025
Merged

Conversation

tasxatzial
Copy link
Member

@tasxatzial tasxatzial commented Mar 25, 2025

Forum topic https://forum.exercism.org/t/luhn-fix-instructions/16242

Summary:

  • Updated the instructions: "credit card numbers" was changed to "numbers"
  • Removed references to fraud from the introduction. According to Wikipedia, the algorithm was designed to protect against accidental errors, not malicious attacks.
  • Updated the headings: There is now a level 2 main heading called "Examples," with each example starting with a level 3 heading.
  • The original examples both used valid/invalid credit card numbers. Since they featured the same type of numbers with an even number of digits, the second example was replaced with an invalid Canadian SIN that has nine digits to better demonstrate the algorithm.
  • Refined the wording throughout the instructions to improve clarity.

@tasxatzial tasxatzial requested a review from a team as a code owner March 25, 2025 20:21
Co-authored-by: Isaac Good <IsaacG@users.noreply.github.com>
@Cool-Katt Cool-Katt merged commit 881373b into exercism:main Mar 26, 2025
7 checks passed
@tasxatzial tasxatzial deleted the luhn-update-docs branch March 26, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants