Skip to content

Commit a0b9de3

Browse files
fix(ui_issues): fix ui issues for other browsers
1 parent b78da16 commit a0b9de3

File tree

5 files changed

+52
-43
lines changed

5 files changed

+52
-43
lines changed

client/src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ const App: React.FC = () => {
119119
return (
120120
<Layout hasSider style={{ minHeight: '100vh', maxHeight: '100vh', overflow: 'scroll' }}>
121121
<Sider collapsible collapsed={collapsed} onCollapse={(value) => setCollapsed(value)}
122-
style={{ overflow: 'auto', height: '100vh', position: 'sticky', top: 0, left: 0 }}>
122+
style={{ overflow: 'auto', position: 'sticky', top: 0, left: 0 }}>
123123
<Menu style={{ minHeight: '92vh' }} defaultSelectedKeys={['project_details']}
124124
selectedKeys={[currentActiveRoute]}
125125
onSelect={(item) => dispatch(setCurrentActiveRoute(item.key))}

client/src/helpers/constants.ts

Lines changed: 51 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,20 @@
11
import { FormFieldProps, InstalledPackageProps, QuestionObject } from "./types";
22

3-
const linter: QuestionObject = {
4-
question_name: 'linter',
5-
question: 'Choose a code linter',
6-
type: 'select',
7-
options: [
8-
{
9-
value: 'eslint',
10-
label: 'ESLint'
11-
},
12-
{
13-
value: 'jshint',
14-
label: 'JSHint'
15-
}
16-
]
17-
};
3+
// const linter: QuestionObject = {
4+
// question_name: 'linter',
5+
// question: 'Choose a code linter',
6+
// type: 'select',
7+
// options: [
8+
// {
9+
// value: 'eslint',
10+
// label: 'ESLint'
11+
// },
12+
// {
13+
// value: 'jshint',
14+
// label: 'JSHint'
15+
// }
16+
// ]
17+
// };
1818

1919
const typeScriptInclusion: QuestionObject = {
2020
question_name: 'ts_preference',
@@ -33,22 +33,22 @@ const typeScriptInclusion: QuestionObject = {
3333
]
3434
};
3535

36-
const unitTestingFramework: QuestionObject = {
37-
question_name: 'unit_test_framework',
38-
logo_name: '',
39-
type: 'select',
40-
question: 'Choose a unit testing framework',
41-
options: [
42-
{
43-
value: 'jest',
44-
label: 'Jest'
45-
},
46-
{
47-
value: 'mocha',
48-
label: 'Mocha'
49-
},
50-
]
51-
};
36+
// const unitTestingFramework: QuestionObject = {
37+
// question_name: 'unit_test_framework',
38+
// logo_name: '',
39+
// type: 'select',
40+
// question: 'Choose a unit testing framework',
41+
// options: [
42+
// {
43+
// value: 'jest',
44+
// label: 'Jest'
45+
// },
46+
// {
47+
// value: 'mocha',
48+
// label: 'Mocha'
49+
// },
50+
// ]
51+
// };
5252

5353
const frontendQuestions: QuestionObject[] = [{
5454
question_name: 'frontend_framework',
@@ -226,8 +226,11 @@ const newProjectQuestions: QuestionObject = {
226226
]
227227
},
228228
typeScriptInclusion,
229-
linter,
230-
unitTestingFramework
229+
/**
230+
* @todo - Intergate linter and testing framework
231+
*/
232+
// linter,
233+
// unitTestingFramework
231234
]
232235
},
233236
{
@@ -246,8 +249,11 @@ const newProjectQuestions: QuestionObject = {
246249
questions: [
247250
...frontendQuestions,
248251
typeScriptInclusion,
249-
linter,
250-
unitTestingFramework
252+
/**
253+
* @todo - Intergate linter and testing framework
254+
*/
255+
// linter,
256+
// unitTestingFramework
251257
]
252258
},
253259
{
@@ -256,8 +262,11 @@ const newProjectQuestions: QuestionObject = {
256262
questions: [
257263
...backendQuestions,
258264
typeScriptInclusion,
259-
linter,
260-
unitTestingFramework
265+
/**
266+
* @todo - Intergate linter and testing framework
267+
*/
268+
// linter,
269+
// unitTestingFramework
261270
]
262271
},
263272
{
@@ -267,8 +276,11 @@ const newProjectQuestions: QuestionObject = {
267276
...frontendQuestions,
268277
...backendQuestions,
269278
typeScriptInclusion,
270-
linter,
271-
unitTestingFramework
279+
/**
280+
* @todo - Intergate linter and testing framework
281+
*/
282+
// linter,
283+
// unitTestingFramework
272284
]
273285
},
274286
]

client/src/index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
body {
88
margin: 0;
9-
place-items: center;
109
min-width: 320px;
1110
}
1211

lib/utils/common-utils.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ const getPackageJson = async (dir) => {
9797
try {
9898
const stats = await stat(pJsonPath);
9999
if (stats.isFile()) {
100-
// eslint-disable-next-line
101100
delete require.cache[require.resolve(pJsonPath)];
102101
return require(pJsonPath);
103102
}

lib/utils/errors.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// eslint-disable-next-line max-classes-per-file
21
import constants from '../constants.js';
32

43
const { statusCodes, messages } = constants;

0 commit comments

Comments
 (0)