Skip to content

Commit 031dbb3

Browse files
bjohansebasbjohansebas
committed
ci: add test for windows
1 parent 4930de7 commit 031dbb3

File tree

2 files changed

+164
-210
lines changed

2 files changed

+164
-210
lines changed

‎.github/workflows/ci.yml

+163-209
Original file line numberDiff line numberDiff line change
@@ -1,236 +1,190 @@
11
name: ci
22

33
on:
4-
- pull_request
5-
- push
4+
push:
5+
branches:
6+
- master
7+
pull_request:
8+
branches:
9+
- master
10+
11+
permissions:
12+
contents: read
13+
14+
# Cancel in progress workflows
15+
# in the scenario where we already had a run going for that PR/branch/tag but then triggered a new run
16+
concurrency:
17+
group: "${{ github.workflow }} ✨ ${{ github.event.pull_request.head.label || github.head_ref || github.ref }}"
18+
cancel-in-progress: true
619

720
jobs:
8-
test:
21+
lint:
22+
name: Lint
923
runs-on: ubuntu-latest
10-
strategy:
11-
matrix:
12-
name:
13-
- Node.js 0.8
14-
- Node.js 0.10
15-
- Node.js 0.12
16-
- io.js 1.x
17-
- io.js 2.x
18-
- io.js 3.x
19-
- Node.js 4.x
20-
- Node.js 5.x
21-
- Node.js 6.x
22-
- Node.js 7.x
23-
- Node.js 8.x
24-
- Node.js 9.x
25-
- Node.js 10.x
26-
- Node.js 11.x
27-
- Node.js 12.x
28-
- Node.js 13.x
29-
- Node.js 14.x
30-
- Node.js 15.x
31-
- Node.js 16.x
32-
- Node.js 17.x
33-
- Node.js 18.x
34-
- Node.js 19.x
35-
- Node.js 20.x
36-
- Node.js 21.x
37-
38-
include:
39-
- name: Node.js 0.8
40-
node-version: "0.8"
41-
npm-i: mocha@2.5.3 supertest@1.1.0
42-
npm-rm: nyc
43-
44-
- name: Node.js 0.10
45-
node-version: "0.10"
46-
npm-i: mocha@2.5.3 nyc@10.3.2 supertest@2.0.0
47-
48-
- name: Node.js 0.12
49-
node-version: "0.12"
50-
npm-i: mocha@2.5.3 nyc@10.3.2 supertest@2.0.0
51-
52-
- name: io.js 1.x
53-
node-version: "1.8"
54-
npm-i: mocha@2.5.3 nyc@10.3.2 supertest@2.0.0
55-
56-
- name: io.js 2.x
57-
node-version: "2.5"
58-
npm-i: mocha@2.5.3 nyc@10.3.2 supertest@2.0.0
59-
60-
- name: io.js 3.x
61-
node-version: "3.3"
62-
npm-i: mocha@2.5.3 nyc@10.3.2 supertest@2.0.0
63-
64-
- name: Node.js 4.x
65-
node-version: "4.9"
66-
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2
67-
68-
- name: Node.js 5.x
69-
node-version: "5.12"
70-
npm-i: mocha@5.2.0 nyc@11.9.0 supertest@3.4.2
71-
72-
- name: Node.js 6.x
73-
node-version: "6.17"
74-
npm-i: mocha@6.2.2 nyc@14.1.1 supertest@6.1.6
75-
76-
- name: Node.js 7.x
77-
node-version: "7.10"
78-
npm-i: mocha@6.2.2 nyc@14.1.1 supertest@6.1.6
24+
steps:
25+
- uses: actions/checkout@v4
26+
- name: Setup Node.js
27+
uses: actions/setup-node@v4
28+
with:
29+
node-version: 'lts/*'
7930

80-
- name: Node.js 8.x
81-
node-version: "8.17"
82-
npm-i: mocha@7.2.0 nyc@14.1.1
31+
- name: Install dependencies
32+
run: npm install --ignore-scripts --include=dev
8333

84-
- name: Node.js 9.x
85-
node-version: "9.11"
86-
npm-i: mocha@7.2.0 nyc@14.1.1
34+
- name: Run lint
35+
run: npm run lint
8736

88-
- name: Node.js 10.x
89-
node-version: "10.24"
90-
npm-i: mocha@8.4.0
37+
test:
38+
name: Run tests
39+
strategy:
40+
fail-fast: false
41+
matrix:
42+
os: [ubuntu-latest, windows-latest]
43+
node-version:
44+
- "0.8"
45+
- "0.10"
46+
- "0.12"
47+
- "4"
48+
- "5"
49+
- "6"
50+
- "7"
51+
- "8"
52+
- "9"
53+
- "10"
54+
- "11"
55+
- "12"
56+
- "13"
57+
- "14"
58+
- "15"
59+
- "16"
60+
- "17"
61+
- "18"
62+
- "19"
63+
- "20"
64+
- "21"
65+
- "22"
66+
- "23"
67+
# Use supported versions of our testing tools under older versions of Node
68+
# Install npm in some specific cases where we need to
69+
include:
70+
include:
71+
- name: Node.js 0.8
72+
node-version: "0.8"
73+
npm-i: mocha@2.5.3 supertest@1.1.0
74+
npm-rm: nyc
75+
- node-version: "0.10"
76+
npm-i: "mocha@3.5.3 nyc@10.3.2 supertest@2.0.0"
77+
# Npm isn't being installed on windows w/ setup-node for
78+
# 0.10 and 0.12, which will end up choking when npm uses es6
79+
npm-version: "npm@2.15.1"
9180

92-
- name: Node.js 11.x
93-
node-version: "11.15"
94-
npm-i: mocha@8.4.0
81+
- node-version: "0.12"
82+
npm-i: "mocha@3.5.3 nyc@10.3.2 supertest@2.0.0"
83+
npm-version: "npm@2.15.11"
9584

96-
- name: Node.js 12.x
97-
node-version: "12.22"
98-
npm-i: mocha@9.2.2
85+
- node-version: "4"
86+
npm-i: "mocha@5.2.0 nyc@11.9.0 supertest@3.4.2"
9987

100-
- name: Node.js 13.x
101-
node-version: "13.14"
102-
npm-i: mocha@9.2.2
88+
- node-version: "5"
89+
npm-i: "mocha@5.2.0 nyc@11.9.0 supertest@3.4.2"
90+
# fixes https://github.com/npm/cli/issues/681
91+
npm-version: "npm@3.10.10"
10392

104-
- name: Node.js 14.x
105-
node-version: "14.21"
93+
- node-version: "6"
94+
npm-i: "mocha@6.2.2 nyc@14.1.1 supertest@3.4.2"
10695

107-
- name: Node.js 15.x
108-
node-version: "15.14"
96+
- node-version: "7"
97+
npm-i: "mocha@6.2.2 nyc@14.1.1 supertest@6.1.6"
10998

110-
- name: Node.js 16.x
111-
node-version: "16.20"
99+
- node-version: "8"
100+
npm-i: "mocha@7.2.0 nyc@14.1.1"
112101

113-
- name: Node.js 17.x
114-
node-version: "17.9"
102+
- node-version: "9"
103+
npm-i: "mocha@7.2.0 nyc@14.1.1"
115104

116-
- name: Node.js 18.x
117-
node-version: "18.19"
105+
- node-version: "10"
106+
npm-i: "mocha@8.4.0"
118107

119-
- name: Node.js 19.x
120-
node-version: "19.9"
108+
- node-version: "11"
109+
npm-i: "mocha@8.4.0"
121110

122-
- name: Node.js 20.x
123-
node-version: "20.11"
111+
- node-version: "12"
112+
npm-i: "mocha@9.2.2"
124113

125-
- name: Node.js 21.x
126-
node-version: "21.6"
114+
- node-version: "13"
115+
npm-i: "mocha@9.2.2"
127116

117+
runs-on: ${{ matrix.os }}
128118
steps:
129-
- uses: actions/checkout@v4
130-
131-
- name: Install Node.js ${{ matrix.node-version }}
132-
shell: bash -eo pipefail -l {0}
133-
run: |
134-
nvm install --default ${{ matrix.node-version }}
135-
if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
136-
nvm install --alias=npm 0.10
137-
nvm use ${{ matrix.node-version }}
138-
sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
139-
npm config set strict-ssl false
140-
fi
141-
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"
142-
143-
- name: Configure npm
144-
run: |
145-
if [[ "$(npm config get package-lock)" == "true" ]]; then
146-
npm config set package-lock false
147-
else
148-
npm config set shrinkwrap false
149-
fi
150-
151-
- name: Remove npm module(s) ${{ matrix.npm-rm }}
152-
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
153-
if: matrix.npm-rm != ''
154-
155-
- name: Install npm module(s) ${{ matrix.npm-i }}
156-
run: npm install --save-dev ${{ matrix.npm-i }}
157-
if: matrix.npm-i != ''
158-
159-
- name: Setup Node.js version-specific dependencies
160-
shell: bash
161-
run: |
162-
# eslint for linting
163-
# - remove on Node.js < 12
164-
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 12 ]]; then
165-
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
166-
grep -E '^eslint(-|$)' | \
167-
sort -r | \
168-
xargs -n1 npm rm --silent --save-dev
169-
fi
170-
171-
- name: Install Node.js dependencies
172-
run: npm install
173-
174-
- name: List environment
175-
id: list_env
176-
shell: bash
177-
run: |
178-
echo "node@$(node -v)"
179-
echo "npm@$(npm -v)"
180-
npm -s ls ||:
181-
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print $2 "=" $3 }' >> "$GITHUB_OUTPUT"
182-
183-
- name: Run tests
184-
shell: bash
185-
run: |
186-
if npm -ps ls nyc | grep -q nyc; then
187-
npm run test-ci
188-
cp coverage/lcov.info "coverage/${{ matrix.node-version }}.lcov"
189-
else
190-
npm test
191-
fi
192-
193-
- name: Lint code
194-
if: steps.list_env.outputs.eslint != ''
195-
run: npm run lint
196-
197-
- name: Collect code coverage
198-
if: steps.list_env.outputs.nyc != ''
199-
run: |
200-
if [[ -d ./coverage ]]; then
201-
mv ./coverage "./${{ matrix.node-version }}"
202-
mkdir ./coverage
203-
mv "./${{ matrix.node-version }}" "./coverage/${{ matrix.node-version }}"
204-
fi
205-
206-
- name: Upload code coverage
207-
uses: actions/upload-artifact@v4
208-
if: steps.list_env.outputs.nyc != ''
209-
with:
210-
name: coverage-${{ matrix.node-version }}
211-
path: "./coverage/${{ matrix.node-version }}"
212-
retention-days: 1
119+
- uses: actions/checkout@v4
120+
with:
121+
persist-credentials: false
122+
123+
- name: Setup Node.js ${{ matrix.node-version }}
124+
uses: actions/setup-node@v4
125+
with:
126+
node-version: ${{ matrix.node-version }}
127+
128+
- name: Npm version fixes
129+
if: ${{matrix.npm-version != ''}}
130+
run: npm install -g ${{ matrix.npm-version }}
131+
132+
- name: Configure npm loglevel
133+
run: |
134+
npm config set loglevel error
135+
shell: bash
136+
137+
- name: Remove npm module(s) ${{ matrix.npm-rm }}
138+
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
139+
if: matrix.npm-rm != ''
140+
141+
- name: Install Node version specific dev deps
142+
if: ${{ matrix.npm-i != '' }}
143+
run: npm install --save-dev ${{ matrix.npm-i }}
144+
145+
- name: Install dependencies
146+
run: npm install
147+
148+
- name: Output Node and NPM versions
149+
run: |
150+
echo "Node.js version: $(node -v)"
151+
echo "NPM version: $(npm -v)"
152+
153+
- name: Run tests
154+
shell: bash
155+
run: npm run test-ci
156+
157+
- name: Upload code coverage
158+
uses: actions/upload-artifact@v4
159+
with:
160+
name: coverage-node-${{ matrix.node-version }}-${{ matrix.os }}
161+
path: ./coverage/lcov.info
162+
retention-days: 1
213163

214164
coverage:
215165
needs: test
216166
runs-on: ubuntu-latest
167+
permissions:
168+
contents: read
169+
checks: write
217170
steps:
218-
- uses: actions/checkout@v4
219-
220-
- name: Install lcov
221-
shell: bash
222-
run: sudo apt-get -y install lcov
223-
224-
- name: Collect coverage reports
225-
uses: actions/download-artifact@v4
226-
with:
227-
path: ./coverage
228-
229-
- name: Merge coverage reports
230-
shell: bash
231-
run: find ./coverage -name lcov.info -exec printf '-a %q\n' {} \; | xargs lcov -o ./coverage/lcov.info
232-
233-
- name: Upload coverage report
234-
uses: coverallsapp/github-action@master
235-
with:
236-
github-token: ${{ secrets.GITHUB_TOKEN }}
171+
- uses: actions/checkout@v4
172+
173+
- name: Install lcov
174+
shell: bash
175+
run: sudo apt-get -y install lcov
176+
177+
- name: Collect coverage reports
178+
uses: actions/download-artifact@v4
179+
with:
180+
path: ./coverage
181+
pattern: coverage-node-*
182+
183+
- name: Merge coverage reports
184+
shell: bash
185+
run: find ./coverage -name lcov.info -exec printf '-a %q\n' {} \; | xargs lcov -o ./lcov.info
186+
187+
- name: Upload coverage report
188+
uses: coverallsapp/github-action@v2
189+
with:
190+
file: ./lcov.info

0 commit comments

Comments
 (0)