Skip to content

Commit 38e4086

Browse files
committed
fix: improve secret option validation in session function
1 parent a3b31f6 commit 38e4086

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ function session(options) {
143143
secrets = [secrets];
144144
}
145145

146-
if (secrets === undefined) {
146+
if (!secrets) {
147147
throw new Error('secret option required for sessions');
148148
}
149149

test/session.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -1178,8 +1178,11 @@ describe('session()', function(){
11781178
});
11791179

11801180
describe('secret option', function () {
1181-
it('should reject without secret', function(){
1182-
assert.throws(session.bind(null, { secret: undefined }), /secret.*required/)
1181+
it('should reject without secret',function () {
1182+
for (const secret of [undefined, null, '', false]) {
1183+
console.log(secret)
1184+
assert.throws(session.bind(null, { secret }), /secret option required for sessions/)
1185+
}
11831186
})
11841187

11851188
it('should reject empty arrays', function () {

0 commit comments

Comments
 (0)