Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: drop nodejs < 18 #1020

Merged
merged 6 commits into from
Mar 16, 2025
Merged

chore: drop nodejs < 18 #1020

merged 6 commits into from
Mar 16, 2025

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Feb 10, 2025 •
edited
Loading

Support for old Node.js is removed, and the express CI is copied :)

@bjohansebas
Copy link
Member Author

@UlisesGascon can you bring the latest changes from the master branch to v2?

@jonchurch jonchurch changed the title chore: drop nodejs 18 chore: drop nodejs < 18 Feb 11, 2025
@jonchurch
Copy link
Member

Ah yeah, I see it needs the commit from Chris to generate a fresh cert

@bjohansebas
Copy link
Member Author

Yep, only you can do it since I don't have the permissions :)

@UlisesGascon UlisesGascon mentioned this pull request Feb 12, 2025
Merged
Phillip9587
Phillip9587 reviewed Feb 13, 2025
View reviewed changes
@Phillip9587
Copy link

I have just left two minor comments.

Also, I wanted to check—do we need to run the CI on windows-latest? The previous workflow only ran on ubuntu-latest. I believe our policy is that lower-level packages only run CI on Linux. Could you confirm if this change is intentional?

Let me know what you think!

@bjohansebas @Phillip9587
Update .github/workflows/ci.yml
72332eb 
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
@bjohansebas
Copy link
Member Author

Well, this is not a lower-level package, but I don't think we want to run tests on Windows here.

@Phillip9587

This comment has been minimized.

Sign in to view
@bjohansebas
Copy link
Member Author

It should have the latest changes from that branch

Phillip9587
Phillip9587 suggested changes Feb 13, 2025
View reviewed changes
@bjohansebas @Phillip9587
Update .github/workflows/ci.yml
be34484 
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
@wesleytodd wesleytodd removed their request for review February 17, 2025 15:24
@bjohansebas
Copy link
Member Author

I would like to move forward with some changes for this package.

@bjohansebas
Copy link
Member Author

cc @UlisesGascon Can you merge this please, or can you make me a committer, please?

@bjohansebas
Copy link
Member Author

This blocked #1025 and #1023.

@UlisesGascon UlisesGascon merged commit d3ab22c into expressjs:v2 Mar 16, 2025
10 checks passed
@UlisesGascon UlisesGascon self-assigned this Mar 16, 2025
@bjohansebas bjohansebas deleted the node18+ branch March 16, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@Phillip9587 Phillip9587 Phillip9587 approved these changes

@jonchurch jonchurch Awaiting requested review from jonchurch

Assignees

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bjohansebas @jonchurch @Phillip9587 @UlisesGascon