lint: upgrade linting environment to ECMAScript 2022 #1030
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphendyr
commented
Mar 18, 2025
raphendyr
commented
Mar 18, 2025
raphendyr
commented
Mar 18, 2025
| @@ -18,7 +18,10 @@ $ npm install express-session | |||
| ## API | |||
|
|
|||
| ```js | |||
| var session = require('express-session') | |||
There was a problem hiding this comment.
This line yielded the following error.
.../express-session/README.md
21:5 error 'session' is assigned a value but never used no-unused-vars
✖ 1 problem (1 error, 0 warnings)
Instead of skipping this, I though it would be ok to expand this introduction usage a bit. What do you think?
raphendyr
commented
Mar 18, 2025
bjohansebas
approved these changes
Mar 18, 2025
UlisesGascon
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the eslint JavaScript linting environment to the 2022 standard. This is based on the wanted Node 18 support and aligns with data in node.green. More importantly, this is what is used in the main express repo currently, see expessjs/express/.eslintrc.yml.
In addition to setting the ES version, we set
nodeenvironment. It's not needed, I think, but makes the file match more with the main repo. The documentation for that says "Node.js global variables and Node.js scoping".See comments below about added rule and the rule we have, which doesn't exists in the main repo.