-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fabfile with new deployment #535
base: next
Are you sure you want to change the base?
Conversation
Maybe it's still best to open it again:/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried not overcomplicating the file
Co-authored-by: AshesOfEther <15670490+AshesOfEther@users.noreply.github.com>
@@ -4,12 +4,14 @@ | |||
@task | |||
def deploy(): | |||
with cd("/data/stregsystem"): | |||
sudo("systemctl stop apache2.service") | |||
sudo("systemctl stop stregsystem.socket") | |||
sudo("systemctl stop stregsystem.service") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the stregsystem.socket and stregsystem.service systemd files located in the repository too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They actually aren't 😓 , do you have an idea for where to store them? Currently, they are just on the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merry christmas also 🎅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're specific to our deployment, hence they're on the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to be able to reproduce the deployement of stregsystemet. But it's up to you all now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AshesOfEther we could make a dedicated prod folder, we already have requirements-prod.txt.
Preferably it would be in a different repo, but FIT has tried that in different capacities https://github.com/f-klubben/server-config and https://github.com/f-klubben/fnix. Otherwise, we could make a dedicated repo for storing files related to the stregsystem deployment. Finally, we could also just add it to server-config to have it somewhere in-case ITS and the server goes awry at the same time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would prefer putting it into another repo
this is where fnix was a good idea, because it would ensure apache, systemd, and whatever else is on git
…vice" This reverts commit 9122863.
I don't think it is necessary to reload apache2.service anymore 🤔