Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fabfile with new deployment #535

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

krestenlaust
Copy link
Member

@krestenlaust krestenlaust commented Dec 2, 2024

I don't think it is necessary to reload apache2.service anymore 🤔

Copy link
Member Author

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried not overcomplicating the file

@krestenlaust krestenlaust marked this pull request as ready for review December 2, 2024 23:47
krestenlaust and others added 2 commits December 14, 2024 03:01
Co-authored-by: AshesOfEther <15670490+AshesOfEther@users.noreply.github.com>
@@ -4,12 +4,14 @@
@task
def deploy():
with cd("/data/stregsystem"):
sudo("systemctl stop apache2.service")
sudo("systemctl stop stregsystem.socket")
sudo("systemctl stop stregsystem.service")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the stregsystem.socket and stregsystem.service systemd files located in the repository too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They actually aren't 😓 , do you have an idea for where to store them? Currently, they are just on the server

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merry christmas also 🎅

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're specific to our deployment, hence they're on the server

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to be able to reproduce the deployement of stregsystemet. But it's up to you all now :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AshesOfEther we could make a dedicated prod folder, we already have requirements-prod.txt.

Preferably it would be in a different repo, but FIT has tried that in different capacities https://github.com/f-klubben/server-config and https://github.com/f-klubben/fnix. Otherwise, we could make a dedicated repo for storing files related to the stregsystem deployment. Finally, we could also just add it to server-config to have it somewhere in-case ITS and the server goes awry at the same time

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would prefer putting it into another repo
this is where fnix was a good idea, because it would ensure apache, systemd, and whatever else is on git

@krestenlaust krestenlaust linked an issue Jan 14, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fabfile outdated after new deployment
4 participants