Skip to content

Commit 5716562

Browse files
committed
addressing code smells
1 parent 70206c1 commit 5716562

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/Waitable.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,14 @@
2020

2121
public interface Waitable<T, P> {
2222

23+
/**
24+
* @deprecated no longer used
25+
*/
2326
@Deprecated
2427
long DEFAULT_INITIAL_BACKOFF_MILLIS = 5L;
28+
/**
29+
* @deprecated no longer used
30+
*/
2531
@Deprecated
2632
double DEFAULT_BACKOFF_MULTIPLIER = 2d;
2733

kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/base/BaseOperation.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,9 +1161,9 @@ public void onDelete(T obj, boolean deletedFinalStateUnknown) {
11611161
} catch (ExecutionException e) {
11621162
throw KubernetesClientException.launderThrowable(e.getCause());
11631163
} catch (TimeoutException e) {
1164-
T item = getItem();
1165-
if (item != null) {
1166-
throw new KubernetesClientTimeoutException(item, amount, timeUnit);
1164+
T i = getItem();
1165+
if (i != null) {
1166+
throw new KubernetesClientTimeoutException(i, amount, timeUnit);
11671167
}
11681168
throw new KubernetesClientTimeoutException(getKind(), getName(), getNamespace(), amount, timeUnit);
11691169
}
@@ -1201,8 +1201,8 @@ public SharedIndexInformer<T> inform(ResourceEventHandler<T> handler, long resyn
12011201
}
12021202

12031203
private DefaultSharedIndexInformer<T, L> createInformer(long resync, Consumer<L> onList, ResourceEventHandler<T> handler) {
1204-
T item = getItem();
1205-
String name = (Utils.isNotNullOrEmpty(getName()) || item != null) ? checkName(item) : null;
1204+
T i = getItem();
1205+
String name = (Utils.isNotNullOrEmpty(getName()) || i != null) ? checkName(i) : null;
12061206

12071207
// use the local context / namespace
12081208
DefaultSharedIndexInformer<T, L> informer = new DefaultSharedIndexInformer<>(getType(), new ListerWatcher<T, L>() {

0 commit comments

Comments
 (0)