Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Upgrade docusaurus version #7244

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

lilshady
Copy link
Contributor

Description

This pull request is to update the docusaurus version
currently, inside lexical-website, the docusaurus/plugin-client-redirects has a different version(3.7.0) so the docusaurus build would fail.

Test plan

Before

when run docusaurus build

Error: Invalid name=docusaurus-plugin-client-redirects version number=3.7.0.
All official @docusaurus/* packages should have the exact same version as @docusaurus/core (number=3.6.0).

After

able to run docusaurus build

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 2:17pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 2:17pm

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I can't remember why we used exact versions in the past. But this seems reasonable

"@docusaurus/preset-classic": "3.6.0",
"@docusaurus/theme-search-algolia": "3.6.0",
"@docusaurus/preset-classic": "^3.6.0",
"@docusaurus/theme-search-algolia": "^3.6.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct

im assuming npm upgrade docusaurus was ran at packages/lexical-website path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@potatowagon
Copy link
Contributor

potatowagon commented Feb 25, 2025

for testing, u can view the generated lexical website at the vercel preview link commented by vercel bot

i checked it looks fine

@potatowagon potatowagon added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit 8e8e45a Feb 25, 2025
49 checks passed
@zurfyx zurfyx deleted the yunclu_fix_docusaurus branch February 28, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants