-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical] Feature: Add listStyleType support to ListNode for customizable list styles #7285
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why you decided to add this property instead of using listNode.setStyle('list-style-type: …')
and implementing the __style
property in createDOM/updateDOM/exportDOM? It's already there, it's just that the DOM methods aren't currently using it (not for a good reason).
The rationale for adding the |
bcece21
to
c1669d4
Compare
Description
Add listStyleType support to ListNode for customizable list styles.
Test plan
Before
By default:
After
When set to
'circle'