[lexical-playground] Feature: Add touch support for TableCellResizer #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibastawisi
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
etrepum
previously approved these changes
Mar 6, 2025
etrepum
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve touch support for the
TableCellResizerplugin.Enhancements to touch support and event handling:
packages/lexical-playground/src/plugins/TableCellResizer/index.css: Added styles for coarse pointer devices to improve touch interaction.packages/lexical-playground/src/plugins/TableCellResizer/index.tsx: ReplacedMouseEventwithPointerEventto handle both mouse and touch events, and added specific handling for touch events such asonTouchMoveandonClick. [1] [2] [3] [4] [5] [6] [7]General improvements:
packages/lexical-playground/src/plugins/TableCellResizer/index.tsx: Updated thezoneWidthand adjusted the calculation of resizer styles for better accuracy and usability.