[lexical-table] Bug Fix: Fix unintended touch table cell selection when scrolling #7309
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibastawisi
requested review from
zurfyx,
fantactuka,
acywatson,
Fetz,
ivailop7,
Sahejkm and
potatowagon
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
ibastawisi
commented
Mar 8, 2025
| ), | ||
| true, | ||
| ); | ||
| tableObserver.pointerType = null; |
There was a problem hiding this comment.
Maybe we should reset the flag regardless of anchor and focus being different, this would only trigger table selection on consecutive tabs on different cells without selection changes between them..
The downside is inconsistent behavior and maybe the flag state gets lost if multiple discrete selection changes happen following a single tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new property to track the type of pointer used and delegates the creation of a table selection until selection change occurs.
This approach would fix #7308.