-
Notifications
You must be signed in to change notification settings - Fork 637
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Migrate publish to gh actions (#1312)
Summary: 2/2 commit converting Circle CI to Github actions. Removed Circle CI to ensure we don't try to publish a version twice. * Added the "deploy" step that only runs for tag pushes * It waits for testing and validation, and fails if either of them fails * This PR uses `--dry-run` to ensure no publish happens unexpectedly. This arg will be removed in a subsequent PR. Pull Request resolved: #1312 Test Plan: Successful CI with no deployment step when a PR is updated- https://github.com/facebook/metro/actions/runs/10269830075 {F1796157419} Successful **DRY RUN** deploy from a hotfix branch (works pretty much the same on main)- https://github.com/facebook/metro/actions/runs/10269576329/job/28415382215 {F1796157706} Deploy fails for a wrongly formatted tag (used tag "bad-tag-name") with a clear error- https://github.com/facebook/metro/actions/runs/10269509288/job/28415186326 {F1796157882} Deploy fails for a tag pushed from a branch **not following** the Metro's release branch naming conventions {F1796158249} Differential Revision: D60961268 Pulled By: vzaidman
- Loading branch information
1 parent
6289dab
commit 501b149
Showing
5 changed files
with
67 additions
and
187 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#!/bin/bash | ||
# Copyright (c) Meta Platforms, Inc. and affiliates. | ||
# | ||
# This source code is licensed under the MIT license found in the | ||
# LICENSE file in the root directory of this source tree. | ||
|
||
echo "Trying to publish the package to npm for tag $RAW_TAG_NAME" | ||
|
||
# Validate tag's format follows conventions eg v0.1.22 or v0.90.2-alpha.5 | ||
if [[ "$RAW_TAG_NAME" =~ ^v[0-9]+(\.[0-9]+){2}(-.*)?$ ]]; then | ||
echo "The tag is valid."; | ||
else | ||
echo "ERROR: The tag's format is wrong."; | ||
exit 1 | ||
fi | ||
|
||
# Does main contain this tag? (regular release workflow) | ||
TAG_ON_MAIN=$(git branch -a --contains "$RAW_TAG_NAME" | grep -cFx ' remotes/origin/main' || true) | ||
echo "Tag is on main branch: $TAG_ON_MAIN" | ||
|
||
# See https://github.com/facebook/metro/pull/1086 regarding handling of hotfix tags | ||
# Deduce the expected name of a release branch for a tag based on Metro's release branch naming convention, eg v0.1.2-alpha.3 -> 0.1.x | ||
RELEASE_BRANCH=$(echo "$RAW_TAG_NAME" | awk -F. '{print substr($1, 2) "." $2 ".x"}') | ||
|
||
# Does a release branch contain this tag? (hotfix workflow) | ||
git fetch origin ${RELEASE_BRANCH} | ||
TAG_ON_RELEASE_BRANCH=$(git branch -a --contains "$RAW_TAG_NAME" | grep -cFx " remotes/origin/$RELEASE_BRANCH" || true) | ||
echo "Tag is on release branch $RELEASE_BRANCH: $TAG_ON_RELEASE_BRANCH" | ||
|
||
if [ $TAG_ON_RELEASE_BRANCH -eq $TAG_ON_MAIN ]; then | ||
echo "Could not determine whether this tag is 'latest' or a hotfix. Aborting." | ||
exit 1 | ||
fi | ||
|
||
NPM_TAG="latest" | ||
# Use a tag name like "0.123-stable" as the dist-tag for a hotfix. This *must not* be valid semver. | ||
[ "$TAG_ON_RELEASE_BRANCH" -eq 1 ] && NPM_TAG="${RELEASE_BRANCH%.x}-stable" | ||
|
||
echo "Publishing with --tag=$NPM_TAG" | ||
|
||
npm run publish --tag="$NPM_TAG" --dry-run |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters