Fabric: Fixes Numeric TextInput not triggering onSubmitEditing (#48276)

zhongwuzw · robhogan · commit 0bcb0c2b2f46 · 2024-12-30T12:16:25.000Z
Summary: Fixes #48259 . The paper code like : https://github.com/facebook/react-native/blob/2fee13094b3d384c071978776fd8b7cff0b6530f/packages/react-native/Libraries/Text/TextInput/RCTBaseTextInputView.mm#L777-L784 ## Changelog: [IOS] [FIXED] - Fabric: Fixes Numeric TextInput not triggering onSubmitEditing Pull Request resolved: #48276 Test Plan: Repro in #48259 Reviewed By: cipolleschi Differential Revision: D67274739 Pulled By: javache fbshipit-source-id: 57396c6e1a8ef96a1b29cae4a9aa9b5f48f6080b
diff --git a/packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm b/packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
@@ -643,6 +643,8 @@ - (void)setDefaultInputAccessoryView
 
 - (void)handleInputAccessoryDoneButton
 {
+  // Ignore the value of whether we submitted; just make sure the submit event is called if necessary.
+  [self textInputShouldSubmitOnReturn];
   if ([self textInputShouldReturn]) {
     [_backedTextInputView endEditing:YES];
   }

Original file line number	Diff line number	Diff line change
`@@ -643,6 +643,8 @@ - (void)setDefaultInputAccessoryView`
`643`	`643`
`644`	`644`	`- (void)handleInputAccessoryDoneButton`
`645`	`645`	`{`
	`646`	`+ // Ignore the value of whether we submitted; just make sure the submit event is called if necessary.`
	`647`	`+ [self textInputShouldSubmitOnReturn];`
`646`	`648`	`if ([self textInputShouldReturn]) {`
`647`	`649`	`[_backedTextInputView endEditing:YES];`
`648`	`650`	`}`