Skip to content

Commit 4b89096

Browse files
joevilchesfacebook-github-bot
authored andcommitted
Fix tons of extra whitespace in OSS feature flag files (#50480)
Summary: Pull Request resolved: #50480 The map in the script has an if in it checking for proper release channel. For feature flags that do not pass this if, they do not have an alternative return, so `map` just maps this to `undefined`. That means there is still an element in this array which gets joined by 2 new lines. As a result every new feature flag will add 2 new lines of white space making these files look rather silly. Fix is to filter undefined out. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D72427349 fbshipit-source-id: 87e1d63c8854652296ce9160ab7171a948983d54
1 parent 3579a89 commit 4b89096

File tree

3 files changed

+3
-158
lines changed

3 files changed

+3
-158
lines changed

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSCanary.h

Lines changed: 1 addition & 75 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<c44a616fd7c941ead315be0b83ae15a7>>
7+
* @generated SignedSource<<db8626cf78a3ed226bbbe6bf20cc03a2>>
88
*/
99

1010
/**
@@ -27,92 +27,18 @@ class ReactNativeFeatureFlagsOverridesOSSCanary : public ReactNativeFeatureFlags
2727
public:
2828
ReactNativeFeatureFlagsOverridesOSSCanary() = default;
2929

30-
31-
32-
33-
34-
35-
36-
37-
38-
39-
40-
41-
4230
bool enableBridgelessArchitecture() override {
4331
return true;
4432
}
4533

46-
47-
48-
49-
50-
51-
5234
bool enableFabricRenderer() override {
5335
return true;
5436
}
5537

56-
57-
58-
59-
60-
61-
62-
63-
64-
65-
66-
67-
68-
69-
70-
71-
72-
73-
74-
75-
76-
77-
78-
79-
80-
81-
82-
83-
84-
85-
86-
87-
88-
89-
90-
91-
92-
93-
94-
95-
96-
97-
98-
99-
100-
101-
102-
103-
104-
105-
106-
107-
10838
bool useNativeViewConfigsInBridgelessMode() override {
10939
return true;
11040
}
11141

112-
113-
114-
115-
11642
bool useTurboModuleInterop() override {
11743
return true;
11844
}

packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSExperimental.h

Lines changed: 1 addition & 83 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* This source code is licensed under the MIT license found in the
55
* LICENSE file in the root directory of this source tree.
66
*
7-
* @generated SignedSource<<ddf338308d0390152ddbec172c0ad40e>>
7+
* @generated SignedSource<<1de02178e1be302bb4b19501950b260a>>
88
*/
99

1010
/**
@@ -28,88 +28,6 @@ class ReactNativeFeatureFlagsOverridesOSSExperimental : public ReactNativeFeatur
2828
ReactNativeFeatureFlagsOverridesOSSExperimental() = default;
2929

3030

31-
32-
33-
34-
35-
36-
37-
38-
39-
40-
41-
42-
43-
44-
45-
46-
47-
48-
49-
50-
51-
52-
53-
54-
55-
56-
57-
58-
59-
60-
61-
62-
63-
64-
65-
66-
67-
68-
69-
70-
71-
72-
73-
74-
75-
76-
77-
78-
79-
80-
81-
82-
83-
84-
85-
86-
87-
88-
89-
90-
91-
92-
93-
94-
95-
96-
97-
98-
99-
100-
101-
102-
103-
104-
105-
106-
107-
108-
109-
110-
111-
112-
11331
};
11432

11533
} // namespace facebook::react

packages/react-native/scripts/featureflags/templates/common-cxx/ReactNativeFeatureFlagsOverridesOSS_Stage_.h-template.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ ${Object.entries(definitions.common)
6868
}`;
6969
}
7070
})
71+
.filter(Boolean)
7172
.join('\n\n')}
7273
};
7374

0 commit comments

Comments
 (0)