Flip mockito usages to mockito-kotlin (#50878)

Summary:
As the repository is moving towards Kotlin and the tests have also been moving towards mockito-kotlin, I'm doing another round here.

## Changelog:

[INTERNAL] - Flip mockito usages to mockito-kotlin

Pull Request resolved: #50878

Test Plan:
```sh
yarn test-android
```

Reviewed By: javache

Differential Revision: D73569293

Pulled By: rshest

fbshipit-source-id: 9bfe7d3f69480367384eafdde429db15eb81d11c

Author: mateoguzmana

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedNodeTraversalTest.kt

@@ -35,14 +35,14 @@ import org.mockito.ArgumentMatchers.any
 import org.mockito.ArgumentMatchers.anyInt
 import org.mockito.ArgumentMatchers.eq
 import org.mockito.MockedStatic
-import org.mockito.Mockito.atMost
-import org.mockito.Mockito.mock
 import org.mockito.Mockito.mockStatic
-import org.mockito.Mockito.reset
-import org.mockito.Mockito.times
-import org.mockito.Mockito.verify
-import org.mockito.Mockito.verifyNoMoreInteractions
-import org.mockito.Mockito.`when` as whenever
+import org.mockito.kotlin.atMost
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.reset
+import org.mockito.kotlin.times
+import org.mockito.kotlin.verify
+import org.mockito.kotlin.verifyNoMoreInteractions
+import org.mockito.kotlin.whenever
 import org.robolectric.RobolectricTestRunner
 
 /** Tests the animated nodes graph traversal algorithm from {@link NativeAnimatedNodesManager}. */
@@ -70,22 +70,22 @@ class NativeAnimatedNodeTraversalTest {
 
     frameTimeNanos = INITIAL_FRAME_TIME_NANOS
 
-    reactApplicationContextMock = mock(ReactApplicationContext::class.java)
+    reactApplicationContextMock = mock<ReactApplicationContext>()
     whenever(reactApplicationContextMock.hasActiveReactInstance()).thenAnswer { true }
     whenever(reactApplicationContextMock.hasCatalystInstance()).thenAnswer { true }
     whenever(reactApplicationContextMock.catalystInstance).thenAnswer { catalystInstanceMock }
     whenever(reactApplicationContextMock.getNativeModule(UIManagerModule::class.java)).thenAnswer {
       uiManagerMock
     }
 
-    catalystInstanceMock = mock(CatalystInstance::class.java)
+    catalystInstanceMock = mock<CatalystInstance>()
     whenever(reactApplicationContextMock.getFabricUIManager()).thenAnswer { uiManagerMock }
     whenever(catalystInstanceMock.getNativeModule(UIManagerModule::class.java)).thenAnswer {
       uiManagerMock
     }
 
-    uiManagerMock = mock(UIManagerModule::class.java)
-    eventDispatcherMock = mock(EventDispatcher::class.java)
+    uiManagerMock = mock<UIManagerModule>()
+    eventDispatcherMock = mock<EventDispatcher>()
     whenever(uiManagerMock.eventDispatcher).thenAnswer { eventDispatcherMock }
     whenever(uiManagerMock.constants).thenAnswer {
       mapOf("customDirectEventTypes" to emptyMap<Any, Any>())
@@ -144,7 +144,7 @@ class NativeAnimatedNodeTraversalTest {
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1, 1, JavaOnlyMap.of("type", "frames", "frames", frames, "toValue", 1.0), animationCallback)
 
@@ -168,7 +168,7 @@ class NativeAnimatedNodeTraversalTest {
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.5, 1.0, 0.5, 0.0)
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
         1,
@@ -201,7 +201,7 @@ class NativeAnimatedNodeTraversalTest {
     createSimpleAnimatedViewWithOpacity()
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
         1,
@@ -231,8 +231,8 @@ class NativeAnimatedNodeTraversalTest {
     createSimpleAnimatedViewWithOpacity()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
 
-    val animationCallback: Callback = mock(Callback::class.java)
-    val valueListener: AnimatedNodeValueListener = mock(AnimatedNodeValueListener::class.java)
+    val animationCallback: Callback = mock<Callback>()
+    val valueListener: AnimatedNodeValueListener = mock<AnimatedNodeValueListener>()
 
     nativeAnimatedNodesManager.startListeningToAnimatedNodeValue(nodeId, valueListener)
     nativeAnimatedNodesManager.startAnimatingNode(
@@ -258,8 +258,8 @@ class NativeAnimatedNodeTraversalTest {
     createSimpleAnimatedViewWithOpacity()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
 
-    val animationCallback: Callback = mock(Callback::class.java)
-    val valueListener: AnimatedNodeValueListener = mock(AnimatedNodeValueListener::class.java)
+    val animationCallback: Callback = mock<Callback>()
+    val valueListener: AnimatedNodeValueListener = mock<AnimatedNodeValueListener>()
 
     nativeAnimatedNodesManager.startListeningToAnimatedNodeValue(nodeId, valueListener)
     nativeAnimatedNodesManager.startAnimatingNode(
@@ -285,7 +285,7 @@ class NativeAnimatedNodeTraversalTest {
   ) {
     createSimpleAnimatedViewWithOpacity()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
 
     nativeAnimatedNodesManager.startAnimatingNode(1, 1, config, animationCallback)
 
@@ -381,7 +381,7 @@ class NativeAnimatedNodeTraversalTest {
   fun testSpringAnimationLoopsFiveTimes() {
     createSimpleAnimatedViewWithOpacity()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
         1,
@@ -460,7 +460,7 @@ class NativeAnimatedNodeTraversalTest {
   fun testDecayAnimation() {
     createSimpleAnimatedViewWithOpacity()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
         1,
@@ -510,7 +510,7 @@ class NativeAnimatedNodeTraversalTest {
   fun testDecayAnimationLoopsFiveTimes() {
     createSimpleAnimatedViewWithOpacity()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
         1,
@@ -563,7 +563,7 @@ class NativeAnimatedNodeTraversalTest {
     createSimpleAnimatedViewWithOpacity()
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 1.0)
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1, 1, JavaOnlyMap.of("type", "frames", "frames", frames, "toValue", 1.0), animationCallback)
 
@@ -620,7 +620,7 @@ class NativeAnimatedNodeTraversalTest {
   fun testAdditionNode() {
     createAnimatedGraphWithAdditionNode()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 1.0)
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
@@ -663,7 +663,7 @@ class NativeAnimatedNodeTraversalTest {
     createAnimatedGraphWithAdditionNode()
 
     // Start animating only the first addition input node
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 1.0)
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
@@ -700,7 +700,7 @@ class NativeAnimatedNodeTraversalTest {
   fun testViewReceiveUpdatesWhenOneOfAnimationHasFinished() {
     createAnimatedGraphWithAdditionNode()
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
 
     // Start animating for the first addition input node, will have 2 frames only
     val firstFrames: JavaOnlyArray = JavaOnlyArray.of(0.0, 1.0)
@@ -758,7 +758,7 @@ class NativeAnimatedNodeTraversalTest {
     nativeAnimatedNodesManager.connectAnimatedNodes(4, 5)
     nativeAnimatedNodesManager.connectAnimatedNodeToView(5, 50)
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 1.0)
     nativeAnimatedNodesManager.startAnimatingNode(
         1, 1, JavaOnlyMap.of("type", "frames", "frames", frames, "toValue", 2.0), animationCallback)
@@ -796,7 +796,7 @@ class NativeAnimatedNodeTraversalTest {
     createSimpleAnimatedViewWithOpacity()
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         404,
         1,
@@ -842,7 +842,7 @@ class NativeAnimatedNodeTraversalTest {
     nativeAnimatedNodesManager.createAnimatedNode(
         tag, JavaOnlyMap.of("type", "value", "value", 1.0, "offset", 0.0))
 
-    val saveValueCallbackMock: Callback = mock(Callback::class.java)
+    val saveValueCallbackMock: Callback = mock<Callback>()
 
     nativeAnimatedNodesManager.getValue(tag, saveValueCallbackMock)
 
@@ -877,7 +877,7 @@ class NativeAnimatedNodeTraversalTest {
     nativeAnimatedNodesManager.connectAnimatedNodes(3, 4)
     nativeAnimatedNodesManager.connectAnimatedNodeToView(4, 50)
 
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.2, 0.4, 0.6, 0.8, 1.0)
     nativeAnimatedNodesManager.startAnimatingNode(
         1,
@@ -1011,7 +1011,7 @@ class NativeAnimatedNodeTraversalTest {
     nativeAnimatedNodesManager.connectAnimatedNodeToView(propsNodeTag, viewTag)
 
     val frames: JavaOnlyArray = JavaOnlyArray.of(0.0, 0.5, 1.0)
-    val animationCallback: Callback = mock(Callback::class.java)
+    val animationCallback: Callback = mock<Callback>()
     nativeAnimatedNodesManager.startAnimatingNode(
         1, 1, JavaOnlyMap.of("type", "frames", "frames", frames, "toValue", 0.0), animationCallback)
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.kt

@@ -13,8 +13,8 @@ import com.facebook.testutils.shadows.ShadowSoLoader
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
-import org.mockito.Mockito.mock
-import org.mockito.Mockito.`when` as whenever
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.whenever
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.annotation.Config
 
@@ -30,14 +30,14 @@ class BaseJavaModuleTest {
 
   @Before
   fun setup() {
-    val jsInstance = mock(JSInstance::class.java)
+    val jsInstance = mock<JSInstance>()
     val moduleHolder = ModuleHolder(MethodsModule())
     moduleWrapper = JavaModuleWrapper(jsInstance, moduleHolder)
     methods = moduleWrapper.methodDescriptors
     val generatedModuleHolder = ModuleHolder(GeneratedMethodsModule())
     generatedModuleWrapper = JavaModuleWrapper(jsInstance, generatedModuleHolder)
     generatedMethods = generatedModuleWrapper.methodDescriptors
-    arguments = mock(ReadableNativeArray::class.java)
+    arguments = mock<ReadableNativeArray>()
   }
 
   private fun findMethod(mname: String, methods: List<JavaModuleWrapper.MethodDescriptor>): Int =

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/ReactTestHelper.kt

@@ -16,8 +16,8 @@ import com.facebook.react.bridge.queue.ReactQueueConfiguration
 import com.facebook.react.bridge.queue.ReactQueueConfigurationImpl
 import com.facebook.react.bridge.queue.ReactQueueConfigurationSpec
 import com.facebook.react.uimanager.UIManagerModule
-import org.mockito.Mockito.mock
-import org.mockito.Mockito.`when` as whenever
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.whenever
 import org.robolectric.RuntimeEnvironment
 
 /** Utility for creating pre-configured instances of core react components for tests. */
@@ -42,10 +42,10 @@ object ReactTestHelper {
             .build()
     val reactQueueConfiguration: ReactQueueConfiguration =
         ReactQueueConfigurationImpl.create(spec) { e -> throw RuntimeException(e) }
-    val reactInstance: CatalystInstance = mock(CatalystInstance::class.java)
+    val reactInstance: CatalystInstance = mock<CatalystInstance>()
     whenever(reactInstance.reactQueueConfiguration).thenReturn(reactQueueConfiguration)
     whenever(reactInstance.getNativeModule(UIManagerModule::class.java))
-        .thenReturn(mock(UIManagerModule::class.java))
+        .thenReturn(mock<UIManagerModule>())
     whenever(reactInstance.isDestroyed).thenReturn(false)
     return reactInstance
   }

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/FabricUIManagerTest.kt

@@ -20,7 +20,7 @@ import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.mockito.MockedStatic
-import org.mockito.Mockito
+import org.mockito.Mockito.mockStatic
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.RuntimeEnvironment
 import org.robolectric.annotation.Config
@@ -37,7 +37,7 @@ class FabricUIManagerTest {
 
   @Before
   fun setup() {
-    featureFlags = Mockito.mockStatic(ReactNativeFeatureFlags::class.java)
+    featureFlags = mockStatic(ReactNativeFeatureFlags::class.java)
     featureFlags.`when`<Boolean> { ReactNativeFeatureFlags.enableFabricLogs() }.thenAnswer { false }
     reactContext = BridgeReactContext(RuntimeEnvironment.getApplication())
     viewManagerRegistry = ViewManagerRegistry(emptyList())

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/fabric/events/TouchEventDispatchTest.kt

@@ -36,9 +36,9 @@ import org.mockito.ArgumentCaptor
 import org.mockito.ArgumentMatchers.*
 import org.mockito.MockedStatic
 import org.mockito.Mockito.mockStatic
-import org.mockito.Mockito.times
-import org.mockito.Mockito.verify
 import org.mockito.kotlin.mock
+import org.mockito.kotlin.times
+import org.mockito.kotlin.verify
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.annotation.Config
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/camera/ImageStoreManagerTest.kt

@@ -17,7 +17,7 @@ import org.assertj.core.api.Assertions.assertThat
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
-import org.mockito.Mockito.*
+import org.mockito.kotlin.mock
 import org.robolectric.RobolectricTestRunner
 
 @RunWith(RobolectricTestRunner::class)
@@ -28,7 +28,7 @@ class ImageStoreManagerTest {
 
   @Before
   fun setUp() {
-    reactApplicationContext = mock(ReactApplicationContext::class.java)
+    reactApplicationContext = mock<ReactApplicationContext>()
     imageStoreManager = ImageStoreManager(reactApplicationContext)
   }
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt

@@ -23,7 +23,10 @@ import org.junit.runner.RunWith
 import org.mockito.ArgumentCaptor
 import org.mockito.ArgumentMatchers
 import org.mockito.MockedStatic
-import org.mockito.Mockito.*
+import org.mockito.Mockito.mockStatic
+import org.mockito.kotlin.spy
+import org.mockito.kotlin.times
+import org.mockito.kotlin.verify
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.RuntimeEnvironment
 

packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/dialog/DialogModuleTest.kt

@@ -18,8 +18,8 @@ import com.facebook.react.bridge.ReactApplicationContext
 import org.assertj.core.api.Assertions.assertThat
 import org.junit.*
 import org.junit.runner.RunWith
-import org.mockito.Mockito.mock
-import org.mockito.Mockito.`when` as whenever
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.whenever
 import org.robolectric.Robolectric
 import org.robolectric.RobolectricTestRunner
 import org.robolectric.Shadows.shadowOf
@@ -182,7 +182,7 @@ class DialogModuleTest {
     // raising an exception
     activity.setTheme(theme)
 
-    val context: ReactApplicationContext = mock(ReactApplicationContext::class.java)
+    val context: ReactApplicationContext = mock<ReactApplicationContext>()
     whenever(context.hasActiveReactInstance()).thenReturn(true)
     whenever(context.currentActivity).thenReturn(activity)