Skip to content

Commit cac27d1

Browse files
cortinicofacebook-github-bot
authored andcommittedApr 16, 2025
Convert to Kotlin - ReactEditText
Summary: This diff converts the last java file inside `com.facebook.react.views.textinput` to Kotlin. As `ReactEditText` is quite involved, reviewing this one is going to be quite critical. I'm marking this as breaking as a number of nullability types has changed for OSS users. Changelog: [Android] [Breaking] - com.facebook.react.views.textinput.ReactEditText is now in Kotlin. If you're subclassing this type you'll need to adjust your signatures. Reviewed By: rshest Differential Revision: D72972921 fbshipit-source-id: 92ed112444cbc20daed5466ad20f651479bfac6f
1 parent 9397b11 commit cac27d1

File tree

5 files changed

+1352
-1499
lines changed

5 files changed

+1352
-1499
lines changed
 

‎packages/react-native/ReactAndroid/api/ReactAndroid.api

+58-49
Original file line numberDiff line numberDiff line change
@@ -6674,31 +6674,31 @@ public abstract interface class com/facebook/react/views/textinput/ContentSizeWa
66746674
}
66756675

66766676
public class com/facebook/react/views/textinput/ReactEditText : androidx/appcompat/widget/AppCompatEditText {
6677-
public static final field DEBUG_MODE Z
6678-
protected field mContainsImages Z
6679-
protected field mDisableTextDiffing Z
6680-
protected field mIsSettingTextFromJS Z
6681-
protected field mIsSettingTextFromState Z
6682-
protected field mNativeEventCount I
6677+
public static final field Companion Lcom/facebook/react/views/textinput/ReactEditText$Companion;
66836678
public fun <init> (Landroid/content/Context;)V
66846679
public fun addTextChangedListener (Landroid/text/TextWatcher;)V
6685-
protected fun applyTextAttributes ()V
6686-
public fun canUpdateWithEventCount (I)Z
6680+
protected final fun applyTextAttributes ()V
6681+
public final fun canUpdateWithEventCount (I)Z
66876682
public fun clearFocus ()V
6688-
protected fun finalize ()V
6689-
public fun getBorderColor (I)I
6690-
public fun getDisableFullscreenUI ()Z
6691-
public fun getReturnKeyType ()Ljava/lang/String;
6692-
public fun getStateWrapper ()Lcom/facebook/react/uimanager/StateWrapper;
6693-
public fun getSubmitBehavior ()Ljava/lang/String;
6694-
protected fun hideSoftKeyboard ()V
6695-
public fun incrementAndGetEventCounter ()I
6683+
protected final fun finalize ()V
6684+
public final fun getBorderColor (I)I
6685+
protected final fun getContainsImages ()Z
6686+
public final fun getDisableFullscreenUI ()Z
6687+
protected final fun getNativeEventCount ()I
6688+
public final fun getReturnKeyType ()Ljava/lang/String;
6689+
public final fun getStagedInputType ()I
6690+
public final fun getStateWrapper ()Lcom/facebook/react/uimanager/StateWrapper;
6691+
public final fun getSubmitBehavior ()Ljava/lang/String;
6692+
protected final fun hideSoftKeyboard ()V
6693+
public final fun incrementAndGetEventCounter ()I
66966694
public fun invalidateDrawable (Landroid/graphics/drawable/Drawable;)V
66976695
public fun isLayoutRequested ()Z
6698-
public fun maybeSetSelection (III)V
6699-
public fun maybeSetTextFromJS (Lcom/facebook/react/views/text/ReactTextUpdate;)V
6700-
public fun maybeSetTextFromState (Lcom/facebook/react/views/text/ReactTextUpdate;)V
6701-
public fun maybeUpdateTypeface ()V
6696+
protected final fun isSettingTextFromJS ()Z
6697+
protected final fun isSettingTextFromState ()Z
6698+
public final fun maybeSetSelection (III)V
6699+
public final fun maybeSetTextFromJS (Lcom/facebook/react/views/text/ReactTextUpdate;)V
6700+
public final fun maybeSetTextFromState (Lcom/facebook/react/views/text/ReactTextUpdate;)V
6701+
public final fun maybeUpdateTypeface ()V
67026702
public fun onAttachedToWindow ()V
67036703
public fun onConfigurationChanged (Landroid/content/res/Configuration;)V
67046704
public fun onCreateInputConnection (Landroid/view/inputmethod/EditorInfo;)Landroid/view/inputmethod/InputConnection;
@@ -6715,43 +6715,52 @@ public class com/facebook/react/views/textinput/ReactEditText : androidx/appcomp
67156715
public fun onTouchEvent (Landroid/view/MotionEvent;)Z
67166716
public fun removeTextChangedListener (Landroid/text/TextWatcher;)V
67176717
public fun requestFocus (ILandroid/graphics/Rect;)Z
6718-
public fun requestFocusFromJS ()V
6719-
public fun setAllowFontScaling (Z)V
6720-
public fun setAutoFocus (Z)V
6718+
public final fun requestFocusFromJS ()V
6719+
public final fun setAllowFontScaling (Z)V
6720+
public final fun setAutoFocus (Z)V
67216721
public fun setBackgroundColor (I)V
6722-
public fun setBorderColor (ILjava/lang/Integer;)V
6723-
public fun setBorderRadius (F)V
6724-
public fun setBorderRadius (FI)V
6725-
public fun setBorderStyle (Ljava/lang/String;)V
6726-
public fun setBorderWidth (IF)V
6727-
public fun setContentSizeWatcher (Lcom/facebook/react/views/textinput/ContentSizeWatcher;)V
6728-
public fun setContextMenuHidden (Z)V
6729-
public fun setDisableFullscreenUI (Z)V
6730-
public fun setFontFamily (Ljava/lang/String;)V
6722+
public final fun setBorderColor (ILjava/lang/Integer;)V
6723+
public final fun setBorderRadius (F)V
6724+
public final fun setBorderRadius (FI)V
6725+
public final fun setBorderStyle (Ljava/lang/String;)V
6726+
public final fun setBorderWidth (IF)V
6727+
protected final fun setContainsImages (Z)V
6728+
public final fun setContentSizeWatcher (Lcom/facebook/react/views/textinput/ContentSizeWatcher;)V
6729+
public final fun setContextMenuHidden (Z)V
6730+
public final fun setDisableFullscreenUI (Z)V
6731+
public final fun setEventDispatcher (Lcom/facebook/react/uimanager/events/EventDispatcher;)V
6732+
public final fun setFontFamily (Ljava/lang/String;)V
67316733
public fun setFontFeatureSettings (Ljava/lang/String;)V
6732-
public fun setFontSize (F)V
6733-
public fun setFontStyle (Ljava/lang/String;)V
6734-
public fun setFontWeight (Ljava/lang/String;)V
6734+
public final fun setFontSize (F)V
6735+
public final fun setFontStyle (Ljava/lang/String;)V
6736+
public final fun setFontWeight (Ljava/lang/String;)V
67356737
public fun setInputType (I)V
6736-
public fun setLetterSpacingPt (F)V
6738+
public final fun setLetterSpacingPt (F)V
67376739
public fun setLineHeight (I)V
6738-
public fun setMaxFontSizeMultiplier (F)V
6739-
public fun setOnKeyPress (Z)V
6740-
public fun setOverflow (Ljava/lang/String;)V
6741-
public fun setPlaceholder (Ljava/lang/String;)V
6742-
public fun setReturnKeyType (Ljava/lang/String;)V
6743-
public fun setScrollWatcher (Lcom/facebook/react/views/textinput/ScrollWatcher;)V
6744-
public fun setSelectTextOnFocus (Z)V
6740+
public final fun setMaxFontSizeMultiplier (F)V
6741+
protected final fun setNativeEventCount (I)V
6742+
public final fun setOnKeyPress (Z)V
6743+
public final fun setOverflow (Ljava/lang/String;)V
6744+
public final fun setPlaceholder (Ljava/lang/String;)V
6745+
public final fun setReturnKeyType (Ljava/lang/String;)V
6746+
public final fun setScrollWatcher (Lcom/facebook/react/views/textinput/ScrollWatcher;)V
6747+
public final fun setSelectTextOnFocus (Z)V
67456748
public fun setSelection (II)V
6746-
public fun setSelectionWatcher (Lcom/facebook/react/views/textinput/SelectionWatcher;)V
6747-
public fun setStateWrapper (Lcom/facebook/react/uimanager/StateWrapper;)V
6748-
public fun setSubmitBehavior (Ljava/lang/String;)V
6749-
public fun shouldBlurOnReturn ()Z
6750-
public fun shouldSubmitOnReturn ()Z
6751-
protected fun showSoftKeyboard ()Z
6749+
protected final fun setSettingTextFromJS (Z)V
6750+
protected final fun setSettingTextFromState (Z)V
6751+
public final fun setStagedInputType (I)V
6752+
public final fun setStateWrapper (Lcom/facebook/react/uimanager/StateWrapper;)V
6753+
public final fun setSubmitBehavior (Ljava/lang/String;)V
6754+
public final fun shouldBlurOnReturn ()Z
6755+
public final fun shouldSubmitOnReturn ()Z
6756+
protected final fun showSoftKeyboard ()Z
67526757
protected fun verifyDrawable (Landroid/graphics/drawable/Drawable;)Z
67536758
}
67546759

6760+
public final class com/facebook/react/views/textinput/ReactEditText$Companion {
6761+
public final fun getDEBUG_MODE ()Z
6762+
}
6763+
67556764
public final class com/facebook/react/views/textinput/ReactTextInputLocalData {
67566765
public fun <init> (Landroid/widget/EditText;)V
67576766
public final fun apply (Landroid/widget/EditText;)V

0 commit comments

Comments
 (0)