Skip to content

Commit e065411

Browse files
mateoguzmanafacebook-github-bot
authored andcommitted
Remove com.facebook.react.modules.network.TLSSocketFactory class (#49457)
Summary: As part of the initiative to reduce the public API surface, I found that this class is not used in the codebase and can be removed. [GH search for TLSSocketFactory](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+com.facebook.react.modules.network.TLSSocketFactory) – this class has some OSS usages, but all the ones I found are from old/non-active repos so that's why I think it is safe to remove but should be marked as [BREAKING] at the same time. ## Changelog: [ANDROID] [BREAKING] - Remove com.facebook.react.modules.network.TLSSocketFactory class Pull Request resolved: #49457 Test Plan: ```sh yarn test-android yarn android ``` Reviewed By: javache Differential Revision: D69736673 Pulled By: cortinico fbshipit-source-id: 1e7abe289cd3894eff5967ae224c3fb8d0501f1a
1 parent 43cffb9 commit e065411

File tree

2 files changed

+0
-89
lines changed

2 files changed

+0
-89
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3359,17 +3359,6 @@ public final class com/facebook/react/modules/network/ReactCookieJarContainer :
33593359
public fun setCookieJar (Lokhttp3/CookieJar;)V
33603360
}
33613361

3362-
public class com/facebook/react/modules/network/TLSSocketFactory : javax/net/ssl/SSLSocketFactory {
3363-
public fun <init> ()V
3364-
public fun createSocket (Ljava/lang/String;I)Ljava/net/Socket;
3365-
public fun createSocket (Ljava/lang/String;ILjava/net/InetAddress;I)Ljava/net/Socket;
3366-
public fun createSocket (Ljava/net/InetAddress;I)Ljava/net/Socket;
3367-
public fun createSocket (Ljava/net/InetAddress;ILjava/net/InetAddress;I)Ljava/net/Socket;
3368-
public fun createSocket (Ljava/net/Socket;Ljava/lang/String;IZ)Ljava/net/Socket;
3369-
public fun getDefaultCipherSuites ()[Ljava/lang/String;
3370-
public fun getSupportedCipherSuites ()[Ljava/lang/String;
3371-
}
3372-
33733362
public final class com/facebook/react/modules/permissions/PermissionsModule : com/facebook/fbreact/specs/NativePermissionsAndroidSpec, com/facebook/react/modules/core/PermissionListener {
33743363
public static final field Companion Lcom/facebook/react/modules/permissions/PermissionsModule$Companion;
33753364
public static final field NAME Ljava/lang/String;

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/TLSSocketFactory.java

Lines changed: 0 additions & 78 deletions
This file was deleted.

0 commit comments

Comments
 (0)