feat: radial gradient iOS #50266
Closed
feat: radial gradient iOS #50266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This was referenced Mar 25, 2025
Closed
|
@jorge-cab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This mostly LGTM but I'd like @joevilches or @NickGerleman to take a look since iOS is not my strong suit |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Summary: Adds JS changes for radial gradient. Previous PR - #50209 ## Changelog: [GENERAL] [ADDED] - Radial gradient <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: #50268 Test Plan: - Added tests in `processBackgroundImage-test.js` in #50268 - Merge this, #50266 and #50269 and check examples in `RadialGradientExample.js` Reviewed By: NickGerleman Differential Revision: D71898524 Pulled By: jorge-cab fbshipit-source-id: 39bdf0f647ba19839b6e6deb09b30a1c337e6457
|
@jorge-cab merged this pull request in d7533dc. |
|
This pull request was successfully merged by @intergalacticspacehighway in d7533dc When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Adds iOS changes for radial gradient. Previous PR - facebook#50209 ## Changelog: [IOS] [ADDED] - Radial gradient <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook#50266 Test Plan: - Added tests in `processBackgroundImage-test.js` in facebook#50268 - Merge this, facebook#50268 and check examples in `RadialGradientExample.js` Reviewed By: joevilches Differential Revision: D71898565 Pulled By: jorge-cab fbshipit-source-id: ac00c7c3cc7dcbe9116c2d60dac8eb1a87153908
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Adds JS changes for radial gradient. Previous PR - facebook#50209 ## Changelog: [GENERAL] [ADDED] - Radial gradient <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: facebook#50268 Test Plan: - Added tests in `processBackgroundImage-test.js` in facebook#50268 - Merge this, facebook#50266 and facebook#50269 and check examples in `RadialGradientExample.js` Reviewed By: NickGerleman Differential Revision: D71898524 Pulled By: jorge-cab fbshipit-source-id: 39bdf0f647ba19839b6e6deb09b30a1c337e6457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds iOS changes for radial gradient. Previous PR - #50209
Changelog:
[IOS] [ADDED] - Radial gradient
Test Plan:
processBackgroundImage-test.jsin feat: radial gradient js prop passing #50268RadialGradientExample.js