Remove .npmignore files from other packages, add lint check #50786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D73031559
Summary: Migrates us from several `.npmignore` files to `package.json#files`, for the main `react-native` package. This reduces the size of our npm package by 38 files — in particular, catching previously missed `__tests__` and `__docs__` directories. ```diff - npm notice package size: 4.4 MB - npm notice unpacked size: 23.7 MB - npm notice total files: 4533 + npm notice package size: 4.4 MB + npm notice unpacked size: 23.7 MB + npm notice total files: 4533 ``` NOTE: `"files"` or `.npmignore` — one or the other! - Having `.npmignore` at the package root does not behave(!). s, having `"files"` as one source of truth is better and safer. See npm/cli#6221. Changelog: [Internal] Differential Revision: D73185321
Summary: Enables us to simplify exclude patterns in `package.json#files`. Changelog: [Internal] Differential Revision: D73185320
Summary: Follows facebook#50784. Having any `.npmignore` files is a gotcha — remove and replace with `package.json#files`. Changelog: [Internal] Differential Revision: D73193257
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73193257 |
|
This pull request has been merged in 16a61bf. |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
…#50786) Summary: Pull Request resolved: facebook#50786 Follows facebook#50784. Having any `.npmignore` files is a gotcha — remove and replace with `package.json#files`. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D73193257 fbshipit-source-id: de715d74195e4f53c817c11f244a61c79b8ce5bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Follows #50784. Having any
.npmignorefiles is a gotcha — remove and replace withpackage.json#files.Changelog: [Internal]
Differential Revision: D73193257