Allow Switch to use default UISwitch accessibility annoucements #50796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73226500 |
joevilches
force-pushed
the
export-D73226500
branch
from
8cf92e8 to
2f6aeb7
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Apr 18, 2025
…book#50796) Summary: When we render a `Switch` today we are never actually focusing on the native `UISwitch` that gets rendered. We instead focus on the parent `RCTViewComponentView` which houses the `UISwitch` as a `contentView`. That is because of [this logic](https://www.internalfb.com/code/fbsource/[b7e1547dab5a]/xplat/js/react-native-github/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm?lines=1211-1213). This blocks the accessibility of any descendants, including the `contentView`. What we lose here is the announcement of "on" and "off" based on the toggle state that comes built into `UISwitch`. To do this today you need to add `accessibilityState={{checked: ...}}` which is very unintuitive. Android DOES announce "on" and "off". We can fix this with an override on the switch class. Changelog: [iOS][Fixed] - Fix "on" and "off" announcements on `Switch` Reviewed By: realsoelynn Differential Revision: D73226500
…book#50796) Summary: Pull Request resolved: facebook#50796 When we render a `Switch` today we are never actually focusing on the native `UISwitch` that gets rendered. We instead focus on the parent `RCTViewComponentView` which houses the `UISwitch` as a `contentView`. That is because of [this logic](https://www.internalfb.com/code/fbsource/[b7e1547dab5a]/xplat/js/react-native-github/packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm?lines=1211-1213). This blocks the accessibility of any descendants, including the `contentView`. What we lose here is the announcement of "on" and "off" based on the toggle state that comes built into `UISwitch`. To do this today you need to add `accessibilityState={{checked: ...}}` which is very unintuitive. Android DOES announce "on" and "off". We can fix this with an override on the switch class. Changelog: [iOS][Fixed] - Fix "on" and "off" announcements on `Switch` Reviewed By: realsoelynn Differential Revision: D73226500
|
This pull request was exported from Phabricator. Differential Revision: D73226500 |
joevilches
force-pushed
the
export-D73226500
branch
from
2f6aeb7 to
407b96c
Compare
|
This pull request has been merged in db6e000. |
|
This pull request was successfully merged by @joevilches in db6e000 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When we render a
Switchtoday we are never actually focusing on the nativeUISwitchthat gets rendered. We instead focus on the parentRCTViewComponentViewwhich houses theUISwitchas acontentView. That is because of this logic. This blocks the accessibility of any descendants, including thecontentView.What we lose here is the announcement of "on" and "off" based on the toggle state that comes built into
UISwitch. To do this today you need to addaccessibilityState={{checked: ...}}which is very unintuitive. Android DOES announce "on" and "off".We can fix this with an override on the switch class.
Changelog: [iOS][Fixed] - Fix "on" and "off" announcements on
SwitchDifferential Revision: D73226500