Remove usage of HERMES_BUILD_APPLE_DSYM #50738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73054511 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Apr 15, 2025
Summary: The implementation of this in Hermes depends on a deprecated CMake feature. Since it just needs to run a command to generate the dSYM, it seems simpler to eliminate the flag and move the work into the RN build script. Differential Revision: D73054511
neildhar
force-pushed
the
export-D73054511
branch
from
d8ac85f to
fcbccd7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73054511 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Apr 15, 2025
Summary: The implementation of this in Hermes depends on a deprecated CMake feature. Since it just needs to run a command to generate the dSYM, it seems simpler to eliminate the flag and move the work into the RN build script. Differential Revision: D73054511
neildhar
force-pushed
the
export-D73054511
branch
from
fcbccd7 to
8b26bac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73054511 |
neildhar
added a commit
to neildhar/react-native
that referenced
this pull request
Apr 16, 2025
Summary: The implementation of this in Hermes depends on a deprecated CMake feature. Since it just needs to run a command to generate the dSYM, it seems simpler to eliminate the flag and move the work into the RN build script. Differential Revision: D73054511
neildhar
force-pushed
the
export-D73054511
branch
from
8b26bac to
429f42c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73054511 |
Summary: The implementation of this in Hermes depends on a deprecated CMake feature. Since it just needs to run a command to generate the dSYM, it seems simpler to eliminate the flag and move the work into the RN build script. Differential Revision: D73054511
neildhar
force-pushed
the
export-D73054511
branch
from
429f42c to
cada751
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73054511 |
|
This pull request has been merged in 6182795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The implementation of this in Hermes depends on a deprecated CMake
feature. Since it just needs to run a command to generate the dSYM, it
seems simpler to eliminate the flag and move the work into the RN build
script.
Differential Revision: D73054511