Skip to content

refactor: migrate BlobProvider.java to Kotlin #50756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JatinDream11
Copy link
Contributor

@JatinDream11 JatinDream11 commented Apr 16, 2025

Summary:

This PR aims to migrate BlobProvider from Java to kotlin as part of 50513

Changelog:

[ANDROID][CHANGED] – Migrate BlobProvider to Kotlin

Test Plan:

Tested on RN tester with both new and old arch

@facebook-github-bot
Copy link
Contributor

Hi @JatinDream11!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 16, 2025
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Apr 16, 2025
@cortinico cortinico requested a review from mateoguzmana April 16, 2025 11:21
Copy link
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the .kt file

@JatinDream11
Copy link
Contributor Author

Added the kotlin file

@cortinico
Copy link
Contributor

@mateoguzmana can you do a first pass?

@mateoguzmana mateoguzmana requested review from mateoguzmana and removed request for mateoguzmana April 17, 2025 09:02
Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left a few things that need to be addressed.

JatinDream11 and others added 3 commits April 21, 2025 12:58
…react/modules/blob/BlobProvider.kt

Co-authored-by: Mateo Guzmán <info@mateoguzman.net>
@JatinDream11
Copy link
Contributor Author

Made the required changes , and commented on few.

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Apr 22, 2025
@facebook-github-bot
Copy link
Contributor

@cortinico merged this pull request in 5d1febf.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @JatinDream11 in 5d1febf

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants