Fix URL parsing to respect node/chromium convention #50757
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73101813 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 16, 2025
Summary: We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
cipolleschi
force-pushed
the
export-D73101813
branch
from
ae60fa8 to
35c1cc0
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Apr 16, 2025
Summary: We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
cipolleschi
force-pushed
the
export-D73101813
branch
from
35c1cc0 to
7f499cc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73101813 |
Summary: Pull Request resolved: facebook#50757 We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Differential Revision: D73101813
|
This pull request was exported from Phabricator. Differential Revision: D73101813 |
cipolleschi
force-pushed
the
export-D73101813
branch
from
7f499cc to
657c0cd
Compare
|
@cipolleschi I missed adding this case(toString) in test cases when I merged URLsearchParams implementation. Should I raise a PR for adding this to testcases? |
|
This pull request has been merged in 6d8a02a. |
|
This pull request was successfully merged by @cipolleschi in 6d8a02a When will my fix make it into a release? | How to file a pick request? |
uffoltzl
pushed a commit
to uffoltzl/react-native
that referenced
this pull request
Apr 18, 2025
Summary: Pull Request resolved: facebook#50757 We received [this issue](facebook#50747) in OSS where the URL parsing logic does not respect node/chromium specs. This can cause issue in usercode. This change fixes it ## Changelog: [General][Fixed] - make sure that URLs are parsed following the node specs Reviewed By: huntie Differential Revision: D73101813 fbshipit-source-id: 36f1d23b3ad7882c16524843621d9ebbcc09b95d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We received this issue in OSS where the URL parsing logic does not respect node/chromium specs.
This can cause issue in usercode. This change fixes it
Changelog:
[General][Fixed] - make sure that URLs are parsed following the node specs
Differential Revision: D73101813