Back out "Migrate ReactActivity" #50998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I'm reverting this as this change is too disruptive for the OSS ecosystem. It will break ALL the apps written in Kotlin and it's coming too close to the branch cut which is in less than one week. We need to re-do this migration in a non breaking manner after the branch cut as this is highly disruptive for little benefit at this point Changelog [Android][Changed] - Back out "[RN][Kotlin] Migrate ReactActivity" Original commit changeset: 936263100ca9 Original Phabricator Diff: D73507044 Differential Revision: D73864144
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73864144 |
|
This pull request has been merged in 0abd5d6. |
|
This pull request was successfully merged by @cortinico in 0abd5d6 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm reverting this as this change is too disruptive for the OSS ecosystem.
It will break ALL the apps written in Kotlin and it's coming too close to the branch cut which is in less than one week.
We need to re-do this migration in a non breaking manner after the branch cut as this is highly disruptive for little benefit at this point
Changelog
[Android][Changed] - Back out "[RN][Kotlin] Migrate ReactActivity"
Original commit changeset: 936263100ca9
Original Phabricator Diff: D73507044
Differential Revision: D73864144